Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

小文字への変換ロジックを tr ベースに変更 #4

Merged
merged 1 commit into from
Apr 29, 2024
Merged

小文字への変換ロジックを tr ベースに変更 #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ runs:

email=''
name=''
user=${USER,,}
user=$(echo $USER | tr [A-Z] [a-z])
if [ $user = 'actions-user' ]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input.user が空だった時にこの if 文は [: =: unexpected operator みたいになっちゃう気がする。。。
16行目の user に default で適当な文字列を突っ込む（error的な）とか、
if [ "$user" = 'actions-user' ]; then みたいにしておくとシェルとして安全。というおせっかい。

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。改良したいと思います 🙇

email='65916846+actions-user@users.noreply.github.com'
name='actions-user'
Expand All @@ -50,7 +50,7 @@ runs:
echo "email: $email"

flag='--local'
if [ ${GLOBAL,,} = 'true' ]; then
if [ $(echo $GLOBAL | tr [A-Z] [a-z]) = 'true' ]; then
flag='--global'
fi
echo "flag: $flag"
Expand Down