-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Add new API endpoints and update Calculator class in LangSmith application #151
Conversation
WalkthroughThe changes in this pull request primarily involve the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/libs/LangSmith/openapi.yaml (1)
227-232
: Consider documenting the performance impact of include_stats parameterThe new
include_stats
parameter with default valuetrue
could have performance implications when retrieving sessions. Consider:
- Documenting the performance impact in the parameter description
- Potentially defaulting to
false
if stats calculation is expensive
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (15)
src/libs/LangSmith/Generated/LangSmith.IPlaygroundSettingsClient.CreatePlaygroundSettings.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.IPlaygroundSettingsClient.UpdatePlaygroundSettings.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.ITracerSessionsClient.ReadTracerSessions.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.CustomChartSeries.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.CustomChartSeriesCreate.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.CustomChartSeriesUpdate.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.OrganizationConfig.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.PlaygroundSettingsCreateRequest.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.PlaygroundSettingsResponse.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.PlaygroundSettingsUpdateRequest.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.PlaygroundSettingsUpdateRequestSettings.Json.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.PlaygroundSettingsUpdateRequestSettings.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.PlaygroundSettingsClient.CreatePlaygroundSettings.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.PlaygroundSettingsClient.UpdatePlaygroundSettings.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.TracerSessionsClient.ReadTracerSessions.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/LangSmith/openapi.yaml
(8 hunks)
🔇 Additional comments (2)
src/libs/LangSmith/openapi.yaml (2)
13251-13255
: LGTM: Workspace-level chart customization
The addition of the optional workspace_id
field to CustomChartSeries schema enables workspace-level customization while maintaining backward compatibility through nullable property.
Also applies to: 13278-13282
13324-13328
: LGTM: Consistent schema updates
The workspace_id field is consistently implemented across related schemas (CustomChartSeries and CustomChartSeriesCreate), maintaining proper schema alignment.
Summary by CodeRabbit
New Features
Alterations