feat:Add API endpoints for managing tracer sessions, organizations, and queues #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes in this pull request introduce new API endpoints for managing tracer sessions, organizations, and annotation queues within the LangSmith platform. Key updates include the addition of methods for creating, updating, and deleting tracer sessions and organizations, as well as managing annotation queues and their associated runs. The modifications enhance the overall functionality and management capabilities of these components. Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
coderabbitai
bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (6)
src/libs/LangSmith/Generated/LangSmith.DatasetsClient.DatasetHandler.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.DatasetsClient.StreamDatasetHandler.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.IDatasetsClient.DatasetHandler.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.IDatasetsClient.StreamDatasetHandler.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.Models.OrganizationConfig.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.Models.PlaygroundRunOverDatasetRequestSchema.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/LangSmith/openapi.yaml(2 hunks)
🔇 Additional comments (1)
src/libs/LangSmith/openapi.yaml (1)
16013-16016: Verify the feature flag implementation
The new feature flag enable_custom_experiment_names is well-defined. However, we should ensure proper implementation across the codebase.
✅ Verification successful
Feature flag implementation is properly integrated
The feature flag enable_custom_experiment_names is correctly implemented:
- It's properly defined in the OpenAPI specification with appropriate default value
- The C# model has been correctly generated with the feature flag as a nullable boolean property
- The flag is positioned logically in the schema alongside other feature flags
- It's related to the
experiment_namefield in theExperimentResultsUploadschema, which suggests proper integration with the experiment naming functionality
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for references to the new feature flag to ensure proper implementation
# Search for any references to the feature flag in the codebase
rg -l "enable_custom_experiment_names"
# Check for any conditional logic related to experiment names
ast-grep --pattern 'experiment_name'
Length of output: 304
Script:
#!/bin/bash
# Let's examine the context around the experiment_name references and the generated C# model
# Check the context around experiment_name in the OpenAPI spec
rg -A 5 -B 5 "experiment_name" src/libs/LangSmith/openapi.yaml
# Check the generated C# model for the feature flag implementation
cat src/libs/LangSmith/Generated/LangSmith.Models.OrganizationConfig.g.cs
Length of output: 11247
| @@ -16447,6 +16451,7 @@ components: | |||
| - manifest | |||
| - secrets | |||
| - options | |||
| - project_name | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Document the new required fields
The addition of project_name and dataset_id as required fields may impact existing API clients. Please ensure these fields are properly documented with:
- Field descriptions
- Format requirements
- Example values
- manifest
- secrets
- options
- project_name
- dataset_id
type: object
properties:
+ project_name:
+ type: string
+ description: "The unique identifier of the project"
+ example: "my-project-123"
+ dataset_id:
+ type: string
+ description: "The unique identifier of the associated dataset"
+ example: "dataset-456"Committable suggestion skipped: line range outside the PR's diff.
This was referenced Dec 3, 2024
Closed
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit