Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide minimal edits when formatting #10

Closed
trixnz opened this issue Jul 17, 2017 · 0 comments
Closed

Provide minimal edits when formatting #10

trixnz opened this issue Jul 17, 2017 · 0 comments

Comments

@trixnz
Copy link
Owner

trixnz commented Jul 17, 2017

When formatting the whole file, we return a single text edit containing the whole formatted document, which can sometimes cause vscode to lose track of the cursor position. According to microsoft/vscode#10133, vscode prefers that extensions provide a minimal number of edits.

We should instead use the proposed --write-mode=diff argument to provide vscode with a minimal number of edits.

This has a dependency on trixnz/lua-fmt#13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant