Support for formatting

[Enzojz]

Hello,

Is it possible to add support to make automatic formatting? Thanks !

best regards,
Zheng

[trixnz]

Hi,
Could you please explain a little more what you mean?

[Enzojz]

Something like formatting with a pretty printer etc...

[trixnz]

Oh, this functionality is already implemented. You can access it via the built in vscode keybinds (Shift + Alt + F on Windows)

[Enzojz]

Hello,

Just have tried it it seems having two problems:

1. After this function, the editor goes to the end of the file, which is very disturbing.
2. It puts all nested tables inline, it should not happen.

Could you improve it?

[trixnz]

Hi,

1. I suspect you may be selecting all of the text before running it, as I just tested it and it worked fine. Can you try again without selecting any text?
2. Please take this to the luafmt issue tracker and create a bug report with a reproduction case and your expected output.

Cheers

[Enzojz]

Hi,

1. I think anyway "jump to the end" when without selecting all is disturbing, since I will lost my input cursor, same as to doing selection all before it, and if I want to format all, why I need to select all?
2. I will create a ticket there.

[trixnz]

You don't need to select all. Here's a video demonstrating how it should work:

[Enzojz]

Ok, I have firgure out what it is:

Because of the first problem, my lua file gets much less lines after formatting, however, the cursor stays always on the same position.

I think it's a bug, since in your video it's not the case.
I am on windows 10.

[Enzojz]

I tested again, it seems context related, I work on a simple code like yours it work correctly, but not on my own real project:

for example this one:

https://github.com/Enzojz/flying_junction_1/blob/master/res/scripts/junction_assoc.lua

I am not sure but perhaps that may caused by unicode letters in the file.

[trixnz]

I looked into it a bit, and its more than likely because luafmt returns the whole formatted file as a single edit. I'll look into adding diff support to luafmt so we can provide minimal edits to vscode.

[Enzojz]

Not sure, since I have tested again on another file, which isn't with any unicode letter, it worked fine.

https://github.com/Enzojz/flying_junction_1/blob/master/res/scripts/junction.lua

Just for information.

[trixnz]

Thanks for the use-cases; I'll use them when implementing diff support. You can follow #10 and trixnz/lua-fmt#13 to keep track of progress.

Apologies for the bugs!

[Enzojz]

Ok. Thank you.

[trixnz]

The new version on the marketplace (0.6.2) should fix this for you. Be advised though, the first format you run may not preserve the cursor position if the file has not been formatted before, as the number of edits will be fairly large and vscode loses track.

After that though, the cursor should stay with you through formats so long as the file is reasonably close to the same layout that luafmt will be outputting.

[Enzojz]

Thank you.

Could you have a look into line breaking issue.

trixnz/lua-fmt#15