[mkFit] Mid-way support for Phase2 initialStep in CMSSW #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct sim label, only dump entries when defined.
…ged in selectHitIndices V1.
- Makefile -- add ShellDict.h to wrap all shell dict includes - Shell dictionary - add dicts for event, hit, track - Shell.cc - add printouts to make clear what seed-cleaning is doing - Event.cc - better hit printout - clear seed lookup after setting new external seed vector - buildtestMPlex.cc - do not enforce simlabel lokup table creation, let it be generated on demand.
…uster charge cut can not be applied to them.
* MkFitCore::TrackerInfo.h
- Add member bool LayerInfo::m_has_charge, defaulting to true.
* RecoTracker/MkFit/plugins/MkFitGeometryESProducer.cc
- Mark phase2 strips as has_charge = false.
- Do not save double-sided detIds.
- Add comment about Phase2 not having TIB or TEC.
* MkFitCore::MkFinder
- Only apply cluster-charge cut when LayerInfo.has_charge == true.
[ This was only done for strip detectors (!pixel) already before. ]
- Reorder / compactify strip cluster compatibility checks.
- Fix printouts for selectHitIndicesV2 (different vars than V1).
* MkFitCore::HitStructures
- Provide LayerInfo as const ref, not pointer.
* val_scripts/validation-cmssw-benchmarks-multiiter.sh
- Add some printouts that make it easier to debug issues with mkFit execution.
- Small changess for Fedora (assuming desktop/laptop).
slava77
reviewed
Mar 28, 2024
slava77
reviewed
Apr 10, 2024
|
there is a merge conflict here now. |
Solved. |
|
Closing in favor of 'compressed' PR #146. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR adds the ability to run mkFit on Phase-2 data / geometry. Only initialStep iteration is supported so far, with a dedicated workflow (
24834.702).Add CMSSW Phase-2 hit and seed converters.
Properly support binary readout for Phase-2 strips where cluster-charge cut can
not be applied.
Improve standalone performance monitoring & debugging tools.
It requires also a new JSON file in cmssw/data repository:
trackreco/RecoTracker-MkFit#3
PR validation:
In TTbar events, with PU:
NOTE: closed in favor of PR #146.