Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mkFit] Mid-way support for Phase2 initialStep in CMSSW #145

Closed
wants to merge 19 commits into from

Commits on Dec 19, 2023

  1. Configuration menu
    Copy the full SHA
    a8b234e View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Configuration menu
    Copy the full SHA
    bb8dec9 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    9c9fd7b View commit details
    Browse the repository at this point in the history
  2. For selHitIndices dumper: use struct Event::SimLabelFromHits to extra…

    …ct sim label, only dump entries when defined.
    osschar committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    3687470 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Proper handling of cands selected for dumping -- FailFlag can be chan…

    …ged in selectHitIndices V1.
    osschar committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    8cda575 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Configuration menu
    Copy the full SHA
    45ddad4 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Configuration menu
    Copy the full SHA
    7374743 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Configuration menu
    Copy the full SHA
    6f20060 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Shell and (semi)-debug printout improvements.

    - Makefile -- add ShellDict.h to wrap all shell dict includes
    
    - Shell dictionary - add dicts for event, hit, track
    
    - Shell.cc - add printouts to make clear what seed-cleaning is doing
    
    - Event.cc
      - better hit printout
      - clear seed lookup after setting new external seed vector
    
    - buildtestMPlex.cc - do not enforce simlabel lokup table creation,
      let it be generated on demand.
    osschar committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a8f0abb View commit details
    Browse the repository at this point in the history
  2. Proper support for Phase2 strips that have binary readout and thus cl…

    …uster charge cut can not be applied to them.
    
    * MkFitCore::TrackerInfo.h
      - Add member bool LayerInfo::m_has_charge, defaulting to true.
    
    * RecoTracker/MkFit/plugins/MkFitGeometryESProducer.cc
      - Mark phase2 strips as has_charge = false.
      - Do not save double-sided detIds.
      - Add comment about Phase2 not having TIB or TEC.
    
    * MkFitCore::MkFinder
      - Only apply cluster-charge cut when LayerInfo.has_charge == true.
        [ This was only done for strip detectors (!pixel) already before. ]
      - Reorder / compactify strip cluster compatibility checks.
      - Fix printouts for selectHitIndicesV2 (different vars than V1).
    
    * MkFitCore::HitStructures
      - Provide LayerInfo as const ref, not pointer.
    
    * val_scripts/validation-cmssw-benchmarks-multiiter.sh
      - Add some  printouts that make it easier to debug issues with mkFit execution.
      - Small changess for Fedora (assuming desktop/laptop).
    osschar committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a8c8349 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    01ed2ef View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    ba831ac View commit details
    Browse the repository at this point in the history
  2. Code-format

    mmasciov committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    a18aa4b View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Configuration menu
    Copy the full SHA
    92869d6 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Internal PR review

    mmasciov committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5f49dbb View commit details
    Browse the repository at this point in the history
  2. Remove redundant line

    mmasciov committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    75c4eb3 View commit details
    Browse the repository at this point in the history
  3. Code-format

    mmasciov committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c0d89a9 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Add dedicated workflow

    mmasciov committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e37f930 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a7f6bf View commit details
    Browse the repository at this point in the history