Support for Phase2 initialStep in CMSSW #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slava77
reviewed
Apr 12, 2024
| continue; | ||
| } | ||
|
|
||
| if (m_XHitSize[itrack] >= MPlexHitIdxMax) | ||
| break; |
There was a problem hiding this comment.
how significant is this change? it seems like the only change that can affect phase-1 setup
|
the bot tests are showing some more significant differences in phase-1. @mmasciov |
|
the most visible seem to be changes in the TIB number of hit distributions or more selectively high purity pt>1 |
slava77
reviewed
May 17, 2024
| isCompatible = | ||
| isStripQCompatible(itrack, layer_of_hits.is_barrel(), m_Err[iP], propPar, m_msErr, m_msPar); | ||
| // rescale strip charge to track parameters and reapply the cut | ||
| if (isCompatible && layer_of_hits.layer_info().has_charge()) { |
There was a problem hiding this comment.
there is
//rescale strip charge to track parameters and reapply the cut
isCompatible &= passStripChargePCMfromTrack(
itrack, layer_of_hits.is_barrel(), charge_pcm[itrack], Hit::minChargePerCM(), propPar, m_msErr);40 lines above without && layer_of_hits.layer_info().has_charge()
I think that's the origin of missing hits in the standalone tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR adds the ability to run mkFit on Phase-2 data / geometry. Only initialStep iteration is supported so far, with a dedicated workflow (
24834.702).Add CMSSW Phase-2 hit and seed converters.
Properly support binary readout for Phase-2 strips where cluster-charge cut can
not be applied.
Improve standalone performance monitoring & debugging tools.
It requires also a new JSON file in cmssw/data repository:
trackreco/RecoTracker-MkFit#3
PR validation:
In TTbar events, with PU: