test(subscriber): remove very flaky tests #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have identified that some of the `console-subscriber` integration tests are flaky (#473). This appears to be a result of the following issue in `tracing` tokio-rs/tracing#2743. Flaky tests are really worse than no tests. So these tests will be removed until the flakiness can be fixed.
Rustin170506
approved these changes
Apr 10, 2024
| @@ -4,35 +4,6 @@ use std::time::Duration; | |||
| use support::{assert_task, ExpectedTask}; | |||
| use tokio::time::sleep; | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
How about we keep the tests but just ignore them by the #[ignore] macro? In the future, we can add it back easily.
There was a problem hiding this comment.
I'd prefer to just remove. We can use #473 to track the need to put them back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have identified that some of the
console-subscriberintegrationtests are flaky (#473). This appears to be a result of the following
issue in
tracingtokio-rs/tracing#2743.Flaky tests are really worse than no tests. So these tests will be
removed until the flakiness can be fixed.