chore: run clippy against all targets #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustin170506
force-pushed
the
rustin-patch-clippy-all
branch
3 times, most recently
from
f818034
to
77c0539
Compare
hds
requested changes
Apr 15, 2024
Rustin170506
force-pushed
the
rustin-patch-clippy-all
branch
2 times, most recently
from
670d55a
to
4c6daa4
Compare
Rustin170506
commented
Apr 17, 2024
This would help us to check if there is any clippy warning in the tests.
Rustin170506
force-pushed
the
rustin-patch-clippy-all
branch
from
7f91d54
to
8cb8202
Compare
|
@hds This PR needs your approval before I can merge it. Could you please take a look? Thanks! |
hds
approved these changes
Apr 22, 2024
Sorry! I didn't realize I was blocking this one. 🤦♀️ |
No worry! Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would help us to check if there is any clippy warning in the tests.
I found it after #544. There are some unused imports in our test code.
Use
cargo clippy --workspace --all-targets --no-deps -- -D warningsto test all targes which include the test targets.