Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(subscriber): remove very flaky tests #544

Merged
merged 1 commit into from
Apr 10, 2024
Merged

test(subscriber): remove very flaky tests #544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions console-subscriber/tests/wake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,6 @@ use std::time::Duration;
use support::{assert_task, ExpectedTask};
use tokio::time::sleep;

#[test]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we keep the tests but just ignore them by the #[ignore] macro? In the future, we can add it back easily.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to just remove. We can use #473 to track the need to put them back.

fn sleep_wakes() {
let expected_task = ExpectedTask::default()
.match_default_name()
.expect_wakes(1)
.expect_self_wakes(0);

let future = async {
sleep(Duration::ZERO).await;
};

assert_task(expected_task, future);
}

#[test]
fn double_sleep_wakes() {
let expected_task = ExpectedTask::default()
.match_default_name()
.expect_wakes(2)
.expect_self_wakes(0);

let future = async {
sleep(Duration::ZERO).await;
sleep(Duration::ZERO).await;
};

assert_task(expected_task, future);
}

#[test]
fn self_wake() {
let expected_task = ExpectedTask::default()
Expand Down
Loading