Cherry pick all 0.4.x #263
Conversation
This PR introduces two simple and lite weight interfaces: - ping to trigger heartbeats without ticking, - status_ref to borrow the progress set instead of cloning.
* raft: leader respond to learner read index message (tikv#220) Signed-off-by: nolouch <nolouch@gmail.com> * Bump to v0.4.3 Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
There was a problem hiding this comment.
Two of the commits are empty and one (bump to 0.4.3) has a description which doesn't reflect the contents (there is no version bump, but is a test). I think it would be better to make the commits a bit more organised, but I don't feel strongly if you want to keep the descriptions matching the 0.4.x branch. Otherwise, it looks good!
|
@nrc some commits are empty because the work has been done in both master and 0.4.x branch. Let's keep the original commit log so that we can trace it one by one. |
|
@overvenus Would you like to take a look? |
src/raft.rs
Outdated
| if m.index < self.raft_log.committed { | ||
| debug!( | ||
| self.logger, | ||
| "got message with lower index than committed."; | ||
| "tag" => &self.tag, | ||
| ); | ||
| let mut to_send = Message::default(); | ||
| to_send.to = m.from; |
src/raft.rs
Outdated
| let mut to_send = Message::default(); | ||
| to_send.to = m.from; |
|
This is blocked by #264. |
BusyJay
dismissed stale reviews from Hoverbear, overvenus, and themself
via
a574621
src/raft.rs
Outdated
| if !ents.is_empty() { | ||
| if !util::is_continuous_ents(msg, ents) { | ||
| return is_batched; | ||
| } | ||
| let mut batched_entries = msg.take_entries(); | ||
| let mut batched_entries: Vec<_> = msg.take_entries().into(); |
There was a problem hiding this comment.
Looks like the conversion is unnecessary.
There was a problem hiding this comment.
take_entries() return a RepeatedField.
There was a problem hiding this comment.
RepeatedField has push too, so I think the conversion is unnecessary.
There was a problem hiding this comment.
The conversion is to support switching prost and rust-protobuf without modification of code.
task list: