support protobuf build by default #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And support prost optionally
|
@BusyJay Seems there are some clippy errors. :( |
|
Because CI in #260 is broken due to the changes to grpcio-compiler is out of sync to protobuf-build. This PR updates protobuf-build to a compatible version. |
|
@BusyJay are you fixing the CI? |
|
Yes. |
hicqu
previously approved these changes
Jul 19, 2019
MyonKeminta
approved these changes
Jul 19, 2019
hicqu
approved these changes
Jul 19, 2019
overvenus
reviewed
Jul 19, 2019
| - cargo test --all -- --nocapture | ||
| # There is a bug in protobuf-build that cached size is not supported yet. |
There was a problem hiding this comment.
Yes. It can be fixed later. Making rust-protobuf back is with highest priority.
overvenus
approved these changes
Jul 19, 2019
This was referenced Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And support prost optionally
This is a derive work of #262 and #260.