raft: leader respond to learner read index message #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nolouch
changed the title
nolouch
force-pushed
the
fix-learner-index
branch
from
73526fb
to
3c983cc
Compare
|
Great Catch, CI failed |
nolouch
force-pushed
the
fix-learner-index
branch
from
a1d4dd8
to
c24275d
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
ice1000
reviewed
Apr 19, 2019
Hoverbear
reviewed
Apr 23, 2019
nolouch
force-pushed
the
fix-learner-index
branch
from
5391796
to
fbc0a9e
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
|
PTAL @Hoverbear @hicqu @ice1000 |
Hoverbear
approved these changes
Apr 29, 2019
hicqu
approved these changes
Apr 30, 2019
|
LGTM |
overvenus
pushed a commit
that referenced
this pull request
May 8, 2019
Signed-off-by: nolouch <nolouch@gmail.com> Signed-off-by: Neil Shen <overvenus@gmail.com>
Merged
|
LGTM |
overvenus
added a commit
that referenced
this pull request
May 8, 2019
* raft: leader respond to learner read index message (#220) Signed-off-by: nolouch <nolouch@gmail.com> * Bump to v0.4.3 Signed-off-by: Neil Shen <overvenus@gmail.com>
hicqu
pushed a commit
to hicqu/raft-rs
that referenced
this pull request
Jul 17, 2019
* raft: leader respond to learner read index message (tikv#220) Signed-off-by: nolouch <nolouch@gmail.com> * Bump to v0.4.3 Signed-off-by: Neil Shen <overvenus@gmail.com>
Hoverbear
pushed a commit
that referenced
this pull request
Jul 19, 2019
* Check pending conf change before campaign (#225) Fix #221. * Add more convenient lite-weight interfaces (#227) This PR introduces two simple and lite weight interfaces: - ping to trigger heartbeats without ticking, - status_ref to borrow the progress set instead of cloning. * *: bump to 0.4.2 (#228) * Bump to v0.4.3 (#231) * raft: leader respond to learner read index message (#220) Signed-off-by: nolouch <nolouch@gmail.com> * Bump to v0.4.3 Signed-off-by: Neil Shen <overvenus@gmail.com> * Request snapshot (#243) Signed-off-by: Neil Shen <overvenus@gmail.com> * fix tests * cargo fmt * address comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a cluster with 1 leader and 1 learner, read request in learner will get an empty read index.
pick from: etcd-io/etcd#10590