simulator: fix some logic bugs

[HunDunDM]

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

Issue Number: Ref #5468

What is changed and how does it work?

Fix logic bugs from #5609 and #5323

Check List

Tests

• Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lhy1024
• rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Base: 75.82% // Head: 75.59% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (9d5aa94) compared to base (fcfcda3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5703      +/-   ##
==========================================
- Coverage   75.82%   75.59%   -0.23%     
==========================================
  Files         329      329              
  Lines       32682    32683       +1     
==========================================
- Hits        24781    24708      -73     
- Misses       5781     5839      +58     
- Partials     2120     2136      +16     

Flag	Coverage Δ
unittests	75.59% <100.00%> (-0.23%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedulers/hot_region.go	85.03% <100.00%> (+0.01%)	⬆️
pkg/dashboard/keyvisual/input/core.go	0.00% <0.00%> (-33.34%)	⬇️
server/api/diagnostic.go	76.92% <0.00%> (-23.08%)	⬇️
pkg/tempurl/tempurl.go	45.00% <0.00%> (-15.00%)	⬇️
server/schedulers/shuffle_hot_region.go	56.00% <0.00%> (-10.00%)	⬇️
server/tso/local_allocator.go	71.62% <0.00%> (-6.76%)	⬇️
server/tso/allocator_manager.go	61.12% <0.00%> (-6.46%)	⬇️
server/storage/kv/etcd_kv.go	79.71% <0.00%> (-5.80%)	⬇️
server/cluster/diagnostic_manager.go	72.04% <0.00%> (-4.31%)	⬇️
server/storage/storage.go	67.30% <0.00%> (-3.85%)	⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rleungx]

/merge

[ti-chi-bot]

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 9d5aa94