simulator: support change peer v2 #5609

HunDunDM · 2022-10-19T03:56:37Z

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

Issue Number: Close #5469

What is changed and how does it work?

Refactor task.go

Split AddVoter and PromoteLearner
Merge AddVoter and AddLearner
- PendingPeer will now be added first, and will be removed after the simulated snap transfer is complete.
Support original ChangePeer in v2 (ChangePeerV2 and len(Changes) == 1)
- Support DemoteVoter, and check if the Peer is not the Leader
Support enter joint state (ChangePeerV2 and len(Changes) > 1)
Support leave joint state (ChangePeerV2 and len(Changes) == 0)
TransferLeader adds Voter checks
TransferLeader supports the parsing field Peers (used to let TiKV find the optimal Peer by itself)
RemovePeer now always also removes the corresponding DownPeer and PendingPeer

Check List

Tests

Manual test (add detailed scripts or steps below)

Release note

None

ti-chi-bot · 2022-10-19T03:56:38Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

bufferflies
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2022-10-19T04:07:20Z

Codecov Report

Base: 75.66% // Head: 75.77% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (527b820) compared to base (d033fbf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5609      +/-   ##
==========================================
+ Coverage   75.66%   75.77%   +0.10%     
==========================================
  Files         327      327              
  Lines       32420    32420              
==========================================
+ Hits        24531    24566      +35     
+ Misses       5770     5748      -22     
+ Partials     2119     2106      -13

Flag	Coverage Δ
unittests	`75.77% <100.00%> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/core/region_option.go	`66.42% <100.00%> (ø)`
pkg/metricutil/metricutil.go	`82.75% <0.00%> (-10.35%)`	⬇️
pkg/tempurl/tempurl.go	`60.00% <0.00%> (-10.00%)`	⬇️
server/schedulers/shuffle_hot_region.go	`56.00% <0.00%> (-10.00%)`	⬇️
...erver/config/service_middleware_persist_options.go	`91.66% <0.00%> (-8.34%)`	⬇️
server/storage/kv/etcd_kv.go	`79.71% <0.00%> (-5.80%)`	⬇️
server/tso/tso.go	`70.22% <0.00%> (-3.38%)`	⬇️
server/member/member.go	`64.21% <0.00%> (-3.16%)`	⬇️
server/cluster/unsafe_recovery_controller.go	`78.27% <0.00%> (-0.69%)`	⬇️
client/base_client.go	`82.77% <0.00%> (-0.48%)`	⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

server/core/region_option.go

tools/pd-simulator/simulator/task.go

lhy1024

Do we need some manual test?

lhy1024 · 2022-10-24T06:37:28Z

tools/pd-simulator/simulator/task.go

+		desc = fmt.Sprintf("merge region %d into %d", regionID, targetRegion.GetId())
+		op = &mergeRegion{targetRegion: targetRegion}
+	case resp.GetSplitRegion() != nil:
+		// TODO: support split region


when will we support it?

We need to discuss how to perform for the three different splits.

Signed-off-by: HunDunDM <hundundm@gmail.com>

nolouch

/merge

ti-chi-bot · 2022-10-26T10:59:15Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

nolouch · 2022-10-27T04:14:52Z

/merge

ti-chi-bot · 2022-10-27T04:14:53Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-10-27T04:14:55Z

This pull request has been accepted and is ready to merge.

Commit hash: ecb7e49

ref #5323, ref #5468, ref #5609 Signed-off-by: HunDunDM <hundundm@gmail.com>

ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 19, 2022

ti-chi-bot requested a review from Yisaer October 19, 2022 03:56

HunDunDM requested review from lhy1024 and removed request for Yisaer October 19, 2022 03:57

HunDunDM added the componet/simulator label Oct 19, 2022

nolouch requested review from nolouch and bufferflies and removed request for nolouch October 20, 2022 14:24

HunDunDM force-pushed the sim-joint branch from 8e431f9 to 44c9107 Compare October 23, 2022 14:47

bufferflies reviewed Oct 24, 2022

View reviewed changes

server/core/region_option.go Outdated Show resolved Hide resolved

bufferflies reviewed Oct 24, 2022

View reviewed changes

tools/pd-simulator/simulator/task.go Outdated Show resolved Hide resolved

lhy1024 reviewed Oct 24, 2022

View reviewed changes

HunDunDM added 6 commits October 26, 2022 16:15

simulator: support change peer v2

0c47b6c

Signed-off-by: HunDunDM <hundundm@gmail.com>

add some comment

7438c4a

Signed-off-by: HunDunDM <hundundm@gmail.com>

tiny fix

7437efa

Signed-off-by: HunDunDM <hundundm@gmail.com>

tiny fix

00d9fd2

Signed-off-by: HunDunDM <hundundm@gmail.com>

tiny fix

85a3a5b

Signed-off-by: HunDunDM <hundundm@gmail.com>

address comment

ecb7e49

Signed-off-by: HunDunDM <hundundm@gmail.com>

HunDunDM force-pushed the sim-joint branch from 44c9107 to ecb7e49 Compare October 26, 2022 08:15

bufferflies approved these changes Oct 26, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2022

nolouch reviewed Oct 26, 2022

View reviewed changes

nolouch approved these changes Oct 27, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2022

Merge branch 'master' into sim-joint

527b820

ti-chi-bot merged commit 7aba282 into tikv:master Oct 27, 2022

HunDunDM deleted the sim-joint branch November 7, 2022 03:13

HunDunDM mentioned this pull request Nov 14, 2022

simulator: fix some logic bugs #5703

Merged

ti-chi-bot pushed a commit that referenced this pull request Nov 15, 2022

simulator: fix some logic bugs (#5703)

8690b96

ref #5323, ref #5468, ref #5609 Signed-off-by: HunDunDM <hundundm@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

simulator: support change peer v2 #5609

simulator: support change peer v2 #5609

HunDunDM commented Oct 19, 2022 •

edited

Loading

ti-chi-bot commented Oct 19, 2022 •

edited

Loading

codecov bot commented Oct 19, 2022 •

edited

Loading

lhy1024 left a comment

lhy1024 Oct 24, 2022

HunDunDM Oct 26, 2022

nolouch left a comment

ti-chi-bot commented Oct 26, 2022

nolouch commented Oct 27, 2022

ti-chi-bot commented Oct 27, 2022

ti-chi-bot commented Oct 27, 2022

simulator: support change peer v2 #5609

simulator: support change peer v2 #5609

Conversation

HunDunDM commented Oct 19, 2022 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot commented Oct 19, 2022 • edited Loading

codecov bot commented Oct 19, 2022 • edited Loading

Codecov Report

lhy1024 left a comment

Choose a reason for hiding this comment

lhy1024 Oct 24, 2022

Choose a reason for hiding this comment

HunDunDM Oct 26, 2022

Choose a reason for hiding this comment

nolouch left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Oct 26, 2022

nolouch commented Oct 27, 2022

ti-chi-bot commented Oct 27, 2022

ti-chi-bot commented Oct 27, 2022

HunDunDM commented Oct 19, 2022 •

edited

Loading

ti-chi-bot commented Oct 19, 2022 •

edited

Loading

codecov bot commented Oct 19, 2022 •

edited

Loading