Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simulator: the operator should share one limiter. #5323

Merged
merged 5 commits into from
Oct 14, 2022
Merged

simulator: the operator should share one limiter. #5323

merged 5 commits into from
Oct 14, 2022

Conversation

bufferflies
Copy link
Contributor

What problem does this PR solve?

Issue Number: Close #5322

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release note

 None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 18, 2022 •
edited
Loading

Codecov Report

Base: 75.73% // Head: 75.65% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (e95d520) compared to base (d70a685).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5323      +/-   ##
==========================================
- Coverage   75.73%   75.65%   -0.08%     
==========================================
  Files         326      326              
  Lines       32253    32253              
==========================================
- Hits        24426    24402      -24     
- Misses       5724     5737      +13     
- Partials     2103     2114      +11
Flag Coverage Δ
unittests 75.65% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/tso/tso.go 66.85% <0.00%> (-6.18%) ⬇️
server/region_syncer/server.go 81.86% <0.00%> (-5.50%) ⬇️
server/tso/allocator_manager.go 62.50% <0.00%> (-2.93%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/server.go 74.43% <0.00%> (-1.02%) ⬇️
server/schedule/operator_controller.go 86.48% <0.00%> (-0.91%) ⬇️
server/schedulers/evict_leader.go 78.57% <0.00%> (-0.90%) ⬇️
server/handler.go 52.70% <0.00%> (-0.39%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bufferflies
simulator
d3e8a46 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
Copy link
Contributor Author

PTAL @lhy1024 @HunDunDM again

@lhy1024 lhy1024 mentioned this pull request Sep 1, 2022
Open
20 tasks
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2022
nolouch
nolouch reviewed Sep 2, 2022
View reviewed changes
tools/pd-simulator/simulator/task.go
// The sending or receiving process has not finished yet.

// store should generate/receive snapshot by chunk size.
for n.limiter.AllowN(int(chunkSize)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cannot be acceleration. we can configure the tick to sped up the simulator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it

@bufferflies
update master
8e7c26b 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2022
@bufferflies
the limit should speed up
5440c6b 
Signed-off-by: bufferflies <1045931706@qq.com>
HunDunDM
HunDunDM approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

tools/pd-simulator/simulator/task.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2022
@bufferflies
pass unit test
44db4fd 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 14, 2022
@nolouch
Copy link
Contributor

nolouch commented Oct 14, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e95d520

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2022
@ti-chi-bot ti-chi-bot merged commit 0a5b7b6 into tikv:master Oct 14, 2022
@bufferflies bufferflies deleted the simulator/snapshot branch October 14, 2022 07:58
@HunDunDM HunDunDM mentioned this pull request Nov 14, 2022
Merged
ti-chi-bot pushed a commit that referenced this pull request Nov 15, 2022
@HunDunDM
simulator: fix some logic bugs (#5703)
8690b96 
ref #5323, ref #5468, ref #5609

Signed-off-by: HunDunDM <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

Assignees
No one assigned
Labels
componet/simulator release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the leader should occupy one io limiter(100MB/s), not every operator.
5 participants
@bufferflies @ti-chi-bot @nolouch @lhy1024 @HunDunDM