Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade etcd to v3.4.3 #1907

Merged
merged 12 commits into from
Nov 19, 2019
Merged

*: upgrade etcd to v3.4.3 #1907

merged 12 commits into from
Nov 19, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Nov 6, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

upgrade etcd to 3.4.3 to fix etcd-io/etcd#10772

What is changed and how it works?

upgrade

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

@nolouch nolouch added the DNM label Nov 6, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
@overvenus
Copy link
Member

make tidy fails.

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor Author

nolouch commented Nov 8, 2019

/run-all-tests

@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #1907 into master will decrease coverage by 0.14%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1907      +/-   ##
==========================================
- Coverage   77.96%   77.82%   -0.15%     
==========================================
  Files         170      170              
  Lines       16875    16879       +4     
==========================================
- Hits        13157    13136      -21     
- Misses       2696     2715      +19     
- Partials     1022     1028       +6
Impacted Files Coverage Δ
pkg/metricutil/metricutil.go 86.11% <77.77%> (-4.52%) ⬇️
server/api/utiletcdhttpapi.go 80% <0%> (-20%) ⬇️
server/kv/etcd_kv.go 72.72% <0%> (-9.1%) ⬇️
pkg/etcdutil/etcdutil.go 82.6% <0%> (-5.8%) ⬇️
server/api/diagnose.go 60.34% <0%> (-5.18%) ⬇️
server/tso/tso.go 77.37% <0%> (-3.65%) ⬇️
server/schedulers/shuffle_hot_region.go 61.29% <0%> (-3.23%) ⬇️
server/member/leader.go 76.53% <0%> (-2.05%) ⬇️
client/client.go 69.18% <0%> (-0.84%) ⬇️
server/coordinator.go 84.3% <0%> (-0.69%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e0143...eabe2ab. Read the comment docs.

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch removed the DNM label Nov 19, 2019
@nolouch
Copy link
Contributor Author

nolouch commented Nov 19, 2019

PTAL @shafreeck

@nolouch nolouch added the type/enhancement The issue or PR belongs to an enhancement. label Nov 19, 2019
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nolouch nolouch added the status/can-merge Indicates a PR has been approved by a committer. label Nov 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

/run-all-tests

@sre-bot sre-bot merged commit 4c0c102 into tikv:master Nov 19, 2019
nolouch added a commit to nolouch/pd that referenced this pull request Nov 27, 2019
nolouch added a commit that referenced this pull request Nov 27, 2019
nolouch added a commit to nolouch/pd that referenced this pull request Dec 27, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants