Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metricutil: upgrade prometheus to v1 #1914

Merged
merged 2 commits into from
Nov 8, 2019
Merged

metricutil: upgrade prometheus to v1 #1914

merged 2 commits into from
Nov 8, 2019

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Upgrade Prometheus to v1, and address recent API changes.

Check List

Tests

  • Unit test
  • Integration test

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added the type/enhancement The issue or PR belongs to an enhancement. label Nov 7, 2019
@disksing
Copy link
Contributor

disksing commented Nov 8, 2019

@overvenus Why not PR to master then cherry-pick to 3.1?

@overvenus
Copy link
Member Author

This change is carried by #1907 .

@nolouch
Copy link
Contributor

nolouch commented Nov 8, 2019

/run-all-tests

@overvenus overvenus merged commit 0e3a054 into release-3.1 Nov 8, 2019
@overvenus overvenus deleted the prome-1 branch November 8, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants