Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "*: upgrade etcd to v3.4.3 (#1907)" #1974

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Nov 27, 2019

This reverts commit 4c0c102.

What problem does this PR solve?

[2019/11/27 18:11:58.366 +08:00] [FATAL] [cluster.go:684] ["invalid downgrade; server version is lower than determined cluster version"] [current-server-version=3.3.0+git] [determined-cluster-version=3.4] [stack="go.etcd.io/etcd/etcdserver/api/membership.mustDetectDowngrade\n\t/Users/nolouch/csn/program/go/pkg/mod/go.etcd.io/etcd@v0.0.0-20190320044326-77d4b742cdbf/etcdserver/api/membership/cluster.go:684\ngo.etcd.io/etcd/etcdserver/api/membership.(*RaftCluster).SetVersion\n\t/Users/nolouch/csn/program/go/pkg/mod/go.etcd.io/etcd@v0.0.0-20190320044326-77d4b742cdbf/etcdserver/api/membership/cluster.go:497\ngo.etcd.io/etcd/etcdserver.(*applierV2store).Put\n\t/Users/nolouch/csn/program/go/pkg/mod/go.etcd.io/etcd@v0.0.0-20190320044326-77d4b742cdbf/etcdserver/apply_v2.go:96\ngo.etcd.io/etcd/etcdserver.(*EtcdServer).applyV2Request\n\t/Users/nolouch/csn/program/go/pkg/mod/go.etcd.io/etcd@v0.0.0-20190320044326-77d4b742cdbf/etcdserver/apply_v2.go:123\ngo.etcd.io/etcd/etcdserver.(*EtcdServer).applyEntryNormal\n\t/Users/nolouch/csn/program/go/pkg/mod/go.etcd.io/etcd@v0.0.0-20190320044326-77d4b742cdbf/etcdserver/server.go:1986\ngo.etcd.io/etcd/etcdserver.(*EtcdServer).apply\n\t/Users/nolouch/csn/program/go/pkg/mod/go.etcd.io/etcd@v0.0.0-20190320044326-77d4b742cdbf/etcdserver/server.go:1925\ngo.etcd.io/etcd/etcdserver.(*EtcdServer).applyEntries\n\t/Users/nolouch/csn/program/go/pkg/mod/go.etcd.io/etcd@v0.0.0-20190320044326-77d4b742cdbf/etcdserver/server.go:1349\ngo.etcd.io/etcd/etcdserver.(*EtcdServer).applyAll\n\t/Users/nolouch/csn/program/go/pkg/mod/go.etcd.io/etcd@v0.0.0-20190320044326-77d4b742cdbf/etcdserver/server.go:1075\ngo.etcd.io/etcd/etcdserver.(*EtcdServer).run.func8\n\t/Users/nolouch/csn/program/go/pkg/mod/go.etcd.io/etcd@v0.0.0-20190320044326-77d4b742cdbf/etcdserver/server.go:1020\ngo.etcd.io/etcd/pkg/schedule.(*fifo).run\n\t/Users/nolouch/csn/program/go/pkg/mod/go.etcd.io/etcd@v0.0.0-20190320044326-77d4b742cdbf/pkg/schedule/schedule.go:157"]

we cannot downgrade the master(etcd v3.4.3) to 3.0(etcd v.3.3.0) now, for the 3.2 branch, temporary revert the #1907
etcd downgrade: etcd-io/etcd#7308

What is changed and how it works?

revert

Check List

Tests

  • Unit test

@codecov-io
Copy link

Codecov Report

Merging #1974 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1974      +/-   ##
==========================================
+ Coverage   77.82%   77.94%   +0.12%     
==========================================
  Files         174      174              
  Lines       17414    17410       -4     
==========================================
+ Hits        13552    13571      +19     
+ Misses       2811     2790      -21     
+ Partials     1051     1049       -2
Impacted Files Coverage Δ
pkg/metricutil/metricutil.go 90.62% <100%> (+4.51%) ⬆️
server/kv/etcd_kv.go 72.72% <0%> (-9.1%) ⬇️
server/api/util.go 63.46% <0%> (-3.85%) ⬇️
server/tso/tso.go 80.29% <0%> (-0.73%) ⬇️
client/client.go 70.02% <0%> (-0.42%) ⬇️
server/cluster.go 82.96% <0%> (-0.25%) ⬇️
server/schedule/operator_controller.go 84.6% <0%> (+0.18%) ⬆️
server/grpc_service.go 59.05% <0%> (+0.64%) ⬆️
pkg/btree/btree.go 87.65% <0%> (+0.8%) ⬆️
server/member/lease.go 93.75% <0%> (+1.56%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b07a7...20fb1e4. Read the comment docs.

@nolouch nolouch added the component/build Build process. label Nov 27, 2019
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a pity!

@nolouch nolouch requested a review from Luffbee November 27, 2019 10:50
Copy link
Contributor

@Luffbee Luffbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch
Copy link
Contributor Author

nolouch commented Nov 27, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 27, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 27, 2019

@nolouch merge failed.

@nolouch
Copy link
Contributor Author

nolouch commented Nov 27, 2019

Failed as expect.

@nolouch nolouch merged commit be73a29 into tikv:master Nov 27, 2019
@nolouch nolouch deleted the revert branch November 27, 2019 12:06
@you06
Copy link
Contributor

you06 commented Nov 28, 2019

Does this fatal happens when a cluster's etcd data already upgraded to 3.4 but the cluster restart with 3.3? If so, the user who use master with #1907 branch will failed with this revert (some long term tests got failed for this). Will the etcd upgrade to 3.4 recently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build Build process. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants