-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "*: upgrade etcd to v3.4.3 (#1907)" #1974
Conversation
This reverts commit 4c0c102.
Codecov Report
@@ Coverage Diff @@
## master #1974 +/- ##
==========================================
+ Coverage 77.82% 77.94% +0.12%
==========================================
Files 174 174
Lines 17414 17410 -4
==========================================
+ Hits 13552 13571 +19
+ Misses 2811 2790 -21
+ Partials 1051 1049 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a pity!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@nolouch merge failed. |
Failed as expect. |
Does this fatal happens when a cluster's etcd data already upgraded to 3.4 but the cluster restart with 3.3? If so, the user who use master with #1907 branch will failed with this revert (some long term tests got failed for this). Will the etcd upgrade to 3.4 recently? |
This reverts commit 4c0c102.
What problem does this PR solve?
we cannot downgrade the master(etcd v3.4.3) to 3.0(etcd v.3.3.0) now, for the
3.2 branch
, temporary revert the #1907etcd downgrade: etcd-io/etcd#7308
What is changed and how it works?
revert
Check List
Tests