Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat: use extra_agg_config_file_system and register bagpacker #242

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Mar 17, 2022

PR Type

  • Improvement

Related Links

autowarefoundation/autoware.universe#537

Description

  • use extra_agg_config_file_system and register bagpacker diag in it

Review Procedure

  • Please confirm related PR is merged.
  • In rqt_robot_monitor, /system/debug_data_logger/storage_error is appeared.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@h-ohta h-ohta marked this pull request as draft March 17, 2022 07:11
@h-ohta
Copy link
Contributor Author

h-ohta commented Mar 17, 2022

I'll change ready after finishing sync-upstream for tier4/autoware.universe

@h-ohta h-ohta marked this pull request as ready for review March 18, 2022 02:53
@h-ohta
Copy link
Contributor Author

h-ohta commented Mar 18, 2022

I finished sync-upstream for tier4/autoware.universe tier4/autoware.universe#20.
So, I'll merge this PR.

@h-ohta h-ohta merged commit ea089ea into tier4/universe Mar 18, 2022
@h-ohta h-ohta deleted the feat/use_extra_agg_system branch March 18, 2022 02:54
s-azumi pushed a commit to s-azumi/autoware_launch that referenced this pull request Apr 21, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
takayuki5168 pushed a commit that referenced this pull request May 26, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
boyali pushed a commit to boyali/autoware_launch that referenced this pull request Jul 26, 2022
…aunch file (tier4#257) (tier4#242)

* feat: change input pointcloud from outside of launch file (tier4#257)

* change localization util input topic

* add arg to input arbitrary lidar topic to perception module

* remove default value except autoware and logging launch

* add default value in localization and perception launch

* remove default value from root launch file

* change input_sensor_points_topic to input/pointcloud

* cosmetic change

* feat: use pointcloud container

* feat: move into util

* ci(pre-commit): autofix

* feat: make final output topic arg

* fix: typo

* fix: some lack things

* fix: revert use pointcloud container

* change to work tutorial

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* change to work tutorial

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: h-ohta <hiroki.ota@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix : to outlier_filtered/pointcloud

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: add missing arg

* fix : topic arg

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Co-authored-by: Taichi Higashide <azumade.30@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: h-ohta <hiroki.ota@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
tier4-autoware-public-bot bot pushed a commit that referenced this pull request Mar 9, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants