Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync tier4/autoware.universe:awf-latest #1752

Merged
merged 25 commits into from
Jan 10, 2025

Conversation

tier4-autoware-public-bot[bot]
Copy link

Features

Bug Fixes

Documentation

Code Refactoring

Tests

Continuous Integrations

Chores

YamatoAndo and others added 25 commits January 7, 2025 18:42
…warefoundation#9787)

* check set intialpose

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* update png

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…on#9597)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…on related members (autowarefoundation#9789)

* chore: input_camera_topics_ is only for debug

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: fuse main message with cached roi messages in fusion_node.cpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: add comments on each process step, organize methods

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: Export process method in fusion_node.cpp

Export the `exportProcess()` method in `fusion_node.cpp` to handle the post-processing and publishing of the fused messages. This method cancels the timer, performs the necessary post-processing steps, publishes the output message, and resets the flags. It also adds processing time for debugging purposes. This change improves the organization and readability of the code.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: Refactor fusion_node.hpp and fusion_node.cpp

Refactor the `fusion_node.hpp` and `fusion_node.cpp` files to improve code organization and readability. This includes exporting the `exportProcess()` method in `fusion_node.cpp` to handle post-processing and publishing of fused messages, adding comments on each process step, organizing methods, and fusing the main message with cached ROI messages. These changes enhance the overall quality of the codebase.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Refactor fusion_node.cpp and fusion_node.hpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Refactor fusion_node.hpp and fusion_node.cpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: Refactor fusion_node.cpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Refactor fusion_node.cpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* feat: implement mutex per 2d detection process

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Refactor fusion_node.hpp and fusion_node.cpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Refactor fusion_node.hpp and fusion_node.cpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* revise template, inputs first and output at the last

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* explicit in and out types 1

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* clarify pointcloud message type

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Refactor fusion_node.hpp and fusion_node.cpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Refactor fusion_node.hpp and fusion_node.cpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Refactor fusion_node.hpp and fusion_node.cpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Refactor publisher types in fusion_node.hpp and node.hpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: resolve cppcheck issue shadowVariable

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Refactor fusion_node.hpp and fusion_node.cpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: rename Det2dManager to Det2dStatus

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* revert mutex related changes

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: review member and method's access

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: resolve shadowVariable of 'det2d'

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix missing line

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor message postprocess and publish methods

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* publish the main message is common

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: replace pointcloud message type by the typename

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* review member access

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* Refactor fusion_node.hpp and fusion_node.cpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: fix condition for publishing painted pointcloud message

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: remove unused variable

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…#9863)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…9862)

refactor: Refactor fusion_node.hpp and fusion_node.cpp for improved code organization and readability

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…es localization/autoware_twist2accel (autowarefoundation#9868)

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
…autowarefoundation#9879)

feat: tier4_debug_msgs to autoware_internal_debug_msgs in files  perception/autoware_multi_object_tracker

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
autowarefoundation#9875)

feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in files perception/autoware_map_based_prediction

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
…ckage.xml (autowarefoundation#9874)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
…ndation#9881)

Removed an unused dependency

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
…ization/autoware_stop_filter (autowarefoundation#9867)

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
…es localization/autoware_pose2twist (autowarefoundation#9866)

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
…ation#9855)

feat(static_centerline_generator): remove the package

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…es localization/autoware_ndt_scan_matcher (autowarefoundation#9861)

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
…s localization/autoware_ekf_localizer (autowarefoundation#9860)

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
autowarefoundation#9880)

feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in files perception/autoware_detection_by_tracker

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
Co-authored-by: Taekjin LEE <taekjin.lee@tier4.jp>
autowarefoundation#9858)

feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in files evaluator/autoware_control_evaluator

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
autowarefoundation#9857)

feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in files control/control_performance_analysis

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
autowarefoundation#9852)

feat: tier4_debug_msgs changed to autoware_internal_msgs in files control/autoware_trajectory_follower_base

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
autowarefoundation#9848)

feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in files control/autoware_pid_longitudinal_controller

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
autowarefoundation#9846)

* feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in files ontrol/autoware_mpc_lateral_controller

Signed-off-by: vish0012 <vishalchhn42@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ndation#9835)

* refactor(lane_change): refactor transit failure function

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fixed failed scenario

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* remove is abort from debug

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* set is abort state

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* add comments for clarity

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* include what you use.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@tier4-autoware-public-bot tier4-autoware-public-bot bot merged commit 3b3d543 into beta/v0.41 Jan 10, 2025
24 of 26 checks passed
@tier4-autoware-public-bot tier4-autoware-public-bot bot deleted the sync-upstream branch January 10, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.