forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(planning_debug_tools): fix a bug of perception reproducer #1577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation#5511) * Refactored landmark_parser Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Renamed landmark_parser to landmark_manager Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed tag_id Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Refactored ar_tag_based_localizer Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix * Added [[nodiscard]] Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Refactored landmark parsing and conversion Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix * Added namespace Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed include Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> --------- Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…arameters (autowarefoundation#5510) * Add extra tag for moving obstacle type Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * add static and moving as parameter postfixes Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * set hysteresis-based obstacle moving classification Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * update config params Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * Use speed norm for object classification Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * changed '_' for '.' to make the code more consistent Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * update documentation Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * move the obstacle moving check to generateSlowDownTrajectory Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove unnecessary reference Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add const to certain variables Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> --------- Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…refoundation#5546) * refactor(goal_planner): add updateStatus and reduce variables Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> refactor Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> refactor Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * move to updatedata Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/goal_planner/goal_planner_module.cpp Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…oundation#5577) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…ation#5575) * fix a bug regarding nearest search --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…utowarefoundation#5554) * refactor(goal_planner): refactoring plan flow and add post process Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> do not decel when searching Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> rename planPullOver Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add plan flow Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add reason of early return Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * typo Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix path_candidate_ Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * pub path candidate after approval Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
…l wall such as MRM (autowarefoundation#5555) * feat: add motion_velocity_smoother's virtual wall Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…on#5439) * Added pose_instability_detector Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Renamed files Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed parameter name Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed to launch Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed to run normally Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed to publish diagnostics Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed a variable name Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed Copyright Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added test Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added maintainer Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added maintainer Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Removed log output Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Modified test Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed comment Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added a test case Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added set_first_odometry_ Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Refactored test Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed test Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed topic name Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed position Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added twist message2 Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed launch Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Updated README.md Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix * Fixed as pointed out by clang-tidy Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Renamed parameters Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed timer Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed README.md Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added debug publishers Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed parameters Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix * Fixed tests Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Changed the type of ekf_to_odom and add const Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed DiagnosticStatus Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Changed odometry_data to std::optional Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Refactored debug output in pose instability detector Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix * Remove warning message for negative time difference in PoseInstabilityDetector Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Updated rqt_runtime_monitor.png Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> --------- Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ts (autowarefoundation#5586) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…file path using get_package_share_directory (autowarefoundation#5588) * use get_package_share_directory Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * use get_package_share_directory in pose_instability_detector Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
…utowarefoundation#5327) * fix: add 3d validation bind function Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: check validation point within shape Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add 2d validator option param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * Revert "chore: refactor" This reverts commit e3cbf6c. * chore: update docs and param file Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * refactor: change to abstract class Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: add maintainer Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
* fix(goal_planner): fix extending current lanes Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix build error Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…efoundation#5599) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…dation#5582) * feat(lane_departure_checker): better cubstones's search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…oundation#5602) Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…oundation#5558) * fix(avoidance): fix wrong reason for unavoidable situation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): fix misreading variable name Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…eter to param file (autowarefoundation#5451) * move radar object clustering parameter to param file Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * remove default parameter settings and fix cmakelists --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
… as true (autowarefoundation#5605) Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
…undation#5557) * fix(avoidance): consider avoidance prepare time Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): consider avoidance prepare distance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): use std::optional Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…refoundation#5572) * fix(avoidance): prevent sudden steering at yield maneuver Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): output debug info Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
* feat(lane_change): cancel hysteresis Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update documentation Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix the explanation of the hysteresis count Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: temkei.kem <1041084556@qq.com>
Signed-off-by: temkei.kem <1041084556@qq.com>
Signed-off-by: temkei.kem <1041084556@qq.com>
Signed-off-by: temkei.kem <1041084556@qq.com>
feat(perception_reproducer): update new perception reproducer for debugging the version of beta/v0.19.1
…ng off blinker at low velocity (#1571) Refactor turn signal decider logic and add support for detecting turn signals in turn lanes Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
fix(planning_debug_tools): fix a bug of perception reproducer
…-proceed fix(lane_change): reduce approval chattering
* feat(out_of_lane): ignore lanelets beyond the last path point Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the psim-ego stops in front of a red traffic light and the rosbag-ego moves at a distance from the psim-ego, the reproducer stops publishing new messages so the psim-ego freezes forever (because the traffic light keeps red forever).
Related links
Parent Issue:
How was this PR tested?
Test with Psim:
(The purple trajectory is rosbag-ego.)
Before:
Screencast from 10-04-2024 06:39:20 PM.webm
After:
Screencast from 10-04-2024 06:38:00 PM.webm
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.