#1815 remove __ngContext__ from snapshots #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnpnl
reviewed
Nov 4, 2022
ahnpnl
pushed a commit
that referenced
this pull request
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
removes
__ngContext__from snapshots.Closes #1815
Test plan
covered by foo component snapshot (see commit)
Does this PR introduce a breaking change?
The existing snapshots need to be updated. However, with every subsequent change of the internal
__ngContext__attribute no change is necessary.Other information
Internal implemenation attribute pollutes the snapshots and should be removed.