Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1815 remove __ngContext__ from snapshots #1816

Merged
merged 4 commits into from
Nov 7, 2022
Merged

#1815 remove __ngContext__ from snapshots #1816

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ab05b2
#1815 remove __ngContext__ from snapshots
jepetko Nov 2, 2022
47da3da
#1815 fix lint
jepetko Nov 2, 2022
f5e7681
#1815 put removable patterns (__ngContext__) into a list
jepetko Nov 4, 2022
e702405
#1815 fixing typo
jepetko Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion e2e/snapshot-serializers/__tests__/__snapshots__/foo.component.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

exports[`snapshot should work 1`] = `
<foo
__ngContext__="0"
condition1={[Function Boolean]}
condition2="false"
value1={[Function String]}
Expand Down
2 changes: 1 addition & 1 deletion src/serializers/ng-snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const print = (fixture: unknown, print: Printer, indent: Indent, opts: PluginOpt
.map((node: VEDebugNode) => Array.from(node.renderElement.childNodes).map(print).join(''))
.join(opts.edgeSpacing);
}
const attributes = Object.keys(componentInstance);
const attributes = Object.keys(componentInstance).filter((key) => key !== '__ngContext__');
ahnpnl marked this conversation as resolved.
Show resolved Hide resolved
if (attributes.length) {
componentAttrs += attributes
.sort()
Expand Down