test(unit): angular v12 example app (the tour of heroes) #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rfprod
changed the title
|
@ahnpnl review please. same source code as for the v11 app but for the v12 app. |
rfprod
changed the title
ahnpnl
reviewed
Dec 4, 2021
examples/example-app-v12/src/app/dashboard/dashboard.component.spec.ts
Outdated
Show resolved
Hide resolved
examples/example-app-v12/src/app/dashboard/dashboard.component.spec.ts
Outdated
Show resolved
Hide resolved
|
@ahnpnl will update the PR soon. I'll update other open PRs accordingly |
- [ ] add angular v12 example app unit tests;
- [x] add the tour of heroes app and specs to the example angular v12 app; - [x] reuse sources tests recently added to the v11 example app; - [x] remove source that are not present in the tour of heroes app; - [X] fix tsconfig - there's no more services dir, map shared instead;
- [X] remove tslint comments; - [X] don't import defitinions from jest/types/* directly;
- [x] don't import definitions from jest/types; - [x] use mockResolvedValue instead of toPromise;
- [X] remove unneeded wait for async;
|
@ahnpnl all done, check again please. |
ahnpnl
reviewed
Dec 4, 2021
- [x] replace the done callback, jest 27 default runner dones not have it any more;
ahnpnl
approved these changes
Dec 4, 2021
|
Thanks!! |
This was referenced Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
servicesdir, map theshareddir instead;Does this PR introduce a breaking change?
Other information
yarn test yarn test-isolated yarn test-esm yarn test-esm-isolated