Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(unit): angular v12 monorepo example app (the tour of heroes) #1181

Merged
merged 5 commits into from
Dec 4, 2021
Merged

test(unit): angular v12 monorepo example app (the tour of heroes) #1181

merged 5 commits into from
Dec 4, 2021

Conversation

rfprod
Copy link
Contributor

@rfprod rfprod commented Nov 18, 2021 •
edited
Loading

Summary

  • add the tour of heroes app and specs to the example angular v12 monorepo app;
  • reuse sources and tests recently added to the v11 example app;
  • remove sources that are not present in the tour of heroes app;
  • fix tsconfig - there's no more services dir, map the shared dir instead;
  • remove tslint comments;
  • use mockResolvedValue instead of toPromise;
  • replace the done callback, jest 27 default runner does not have it any more;

Does this PR introduce a breaking change?

  • No

Other information

  • verify tests workability locally:
yarn test
yarn test-isolated
yarn test-esm
yarn test-esm-isolated

@rfprod rfprod mentioned this pull request Nov 18, 2021
Closed
3 tasks
@rfprod rfprod changed the title test(unit): angular v12 monorepo example app unit tests test(unit): angular v12 monorepo example app unit tests (the tour of heroes) Dec 4, 2021
@rfprod rfprod marked this pull request as ready for review December 4, 2021 09:39
@rfprod rfprod changed the title test(unit): angular v12 monorepo example app unit tests (the tour of heroes) test(unit): angular v12 monorepo example app (the tour of heroes) Dec 4, 2021
@rfprod
Copy link
Contributor Author

rfprod commented Dec 4, 2021

@ahnpnl review please. same source code as for the v11 app but for the v12 monorepo.

@rfprod rfprod mentioned this pull request Dec 4, 2021
Closed
@rfprod rfprod marked this pull request as draft December 4, 2021 11:13
@rfprod rfprod marked this pull request as ready for review December 4, 2021 12:11
@rfprod rfprod marked this pull request as draft December 4, 2021 12:16
@rfprod rfprod marked this pull request as ready for review December 4, 2021 13:02
rfprod added 5 commits December 4, 2021 16:07
@rfprod
test(unit): angular v12 monorepo example app unit tests
8799bb8 
- [ ] add angular v12 monorepo example app unit tests;
@rfprod
test(unit): angular v12 mono example app unit tests (the tour of heroes)
86f86ce 
- [x] add the tour of heroes app and specs to the example angular v12 monorepo app;
- [x] reuse
sources and tests recently added to the v11 example app;
- [x] remove sources that are not present
in the tour of heroes app;
- [x] fix tsconfig - there's no more services dir, map the shared dir
instead;
@rfprod
test(cleanup): clean up unit tests
f502696 
- [x] don't import definitions from jest/types;
- [x] use mockResolvedValue instead of
toPromise;
- [X] remove tslint comments;
- [X] remove unneeded wait for async;
@rfprod
fix(test): replace the done callback
af9f3c5 
- [x] replace the done callback, jest 27 default runner dones not have it any more;
@rfprod
fix(test): replace the done callback
cb8b6e1 
- [x] replace the done callback, jest 27 default runner dones not have it any more;
@rfprod
Copy link
Contributor Author

rfprod commented Dec 4, 2021 •
edited
Loading

@ahnpnl addressed same issues as in

review please

ahnpnl
ahnpnl approved these changes Dec 4, 2021
View reviewed changes
Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@ahnpnl ahnpnl merged commit 820a4c4 into thymikee:main Dec 4, 2021
@rfprod rfprod deleted the unit-test-v12-monorepo branch December 4, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahnpnl ahnpnl ahnpnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfprod @ahnpnl