test(unit): yarn workspace angular v12 example app (the tour of heroes) #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rfprod
changed the title
rfprod
changed the title
rfprod
changed the title
|
@ahnpnl review please. same source code as for the v11 app but for the v12 yarn workspace. |
- [ ] add yarn workspace example app unit tests;
- [x] add the tour of heroes app and specs to the example yarn workspace app; - [x] reuse sources and tests recently added to the v11 example app; - [x] remove sources that are not present in the tour of heroes app; - [x] enable strict compiler mode; - [x] fix tsconfig - there's no more services dir, map the shared dir instead;
- [x] use mockResolvedValue instead of toPromise; - [X] remove tslint comments; - [X] remove unneeded wait for async; - [x] replace the done callback, jest 27 default runner dones not have it any more;
|
@ahnpnl addressed same issues as in review please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
servicesdir, map theshareddir instead;Does this PR introduce a breaking change?
Other information
yarn test yarn test-isolated yarn test-esm yarn test-esm-isolated