Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to example app #110

Closed
thymikee opened this issue Dec 21, 2017 · 6 comments
Closed

Add more tests to example app #110

thymikee opened this issue Dec 21, 2017 · 6 comments

Comments

@thymikee
Copy link
Owner

In the example dir of this repository we have couple of tests to check if we didn't break some common testing cases. It is a very simple app and I treat it as sanity check before releasing. Also, a good reference for anybody wanting to see how to write specific tests. It would be nice to extend this test suite, to cover more cases, so we have more confidence in further releases.

Since I'm not actively involved in any Angular project for quite some time and I still want this project to be alive, I reach out to you as a community to help with this task. I'm sure we can make this project more stable with every release.

If anyone is interested in contributing tests, please let me know by either commenting in this thread or sending a PR 🙂

ParkerM added a commit to ParkerM/jest-preset-angular that referenced this issue Aug 26, 2018
This was causing the linter to complain about existing imports (e.g. in hero service)
ParkerM added a commit to ParkerM/jest-preset-angular that referenced this issue Aug 26, 2018
ParkerM added a commit to ParkerM/jest-preset-angular that referenced this issue Aug 26, 2018
ParkerM added a commit to ParkerM/jest-preset-angular that referenced this issue Aug 26, 2018
ParkerM added a commit to ParkerM/jest-preset-angular that referenced this issue Aug 26, 2018
@ahmedifhaam
Copy link

I need some help I am currently using JEST to test an angular 9 app, There i want to mock service classes which are dependencies for my component. I want my tests to take a default mock from mocks folder and if i need i will override with mockImplementaion(). currently its working if i import the mock file but i think the way jest documentation says it should pick the mock when i call jest.mock('filepath'). In my case its not working

@wtho
Copy link
Collaborator

wtho commented Mar 28, 2020

@ahmedifhaam best would be you either create a PR with the test case not working in example app, or you create another new issue with your specific request and provide a minimal reproduction in form of an own, linked repository, that will enable us to help you quickly.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Dec 4, 2021

Closes via all mentioned MRs above.

@ahnpnl ahnpnl closed this as completed Dec 4, 2021
@wtho
Copy link
Collaborator

wtho commented Dec 4, 2021

Just wondering - does the V10 example app also get the tour of heroes tests?
Totally ok for me if not, but just wanted to make sure this was not just left out my mistake, but on purpose.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Dec 4, 2021

Angular 10 support will be dropped on 24th this month so we don’t need to add tests to example app Angular 10 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants