[Draft] Python 3.6 Upgrade / AMO Rebase #305
Draft
+78,564
−233,342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Localization authors: - goofy <goofy@babelzilla.org>
* Extract version source asynchronously. Fixes #10566 * Fix circular import that magically nullifies elasticsearch mocks * Fix more mock paths, restore import
Localization authors: - Théo Chevalier <theo.chevalier11@gmail.com>
Localization authors: - goofy <goofy@babelzilla.org>
Python 3 fixes for 'files'
Hopefully fixes #10563
It's been passing reliably since we upgraded to pytest 4.2.0
* Fix missing languages in stats from product_details. Some parts actually... need all the languages. Fixes mozilla/addons#891 * Remove dbg locale, fix ordering for py3
Fix devhub tests for python3
Localization authors: - Rodrigo <rodrigo.mcunha@hotmail.com>
It depends on the cache key being different for the cached compat info, and using seconds precision to generate it wasn't enough. We could probably use a completely random value instead, but switching to milliseconds keeps it an ever-incrementing value as before and should be safer. Fix #10599
Localization authors: - Pin-guang Chen <petercpg@mail.moztw.org>
Localization authors: - Pin-guang Chen <petercpg@mail.moztw.org>
Localization authors: - Mark Heijl <markh@babelzilla.org>
Localization authors: - 우믿트 <eloli@foxmail.com>
Localization authors: - Michael Wolf <milupo@sorbzilla.de>
Localization authors: - Marcelo Ghelman <marcelo.ghelman@gmail.com>
We now have the expected values for some of the fields. In addition, some of the fields that had equivalents in our other APIs are renamed to match the rest of the API better.
* Update django-waffle from 0.14.0 to 0.15.1 * Flush waffle after changing their values in tests
Localization authors: - Andreas Pettersson <az@kth.se>
Localization authors: - Balázs Meskó <meskobalazs@gmail.com>
Localization authors: - Théo Chevalier <theo.chevalier11@gmail.com>
Localization authors: - Kohei Yoshino <kohei.yoshino@gmail.com>
Localization authors: - ItielMaN <itiel_yn8@walla.com>
Localization authors: - Michael Wolf <milupo@sorbzilla.de>
Localization authors: - goofy <goofy@babelzilla.org>
Python 3.6 Test Results5 500 tests 5 322 ✅ 21m 27s ⏱️ For more details on these failures, see this check. Results for commit 9e85106. ♻️ This comment has been updated with latest results. |
MelissaAutumn
force-pushed
the
master-2019
branch
from
bf8c00d to
988b4ce
Compare
* Don't generate Firefox/Android addons for local dev * Set Thunderbird as the default app * Only enable Firefox/Android if in tests * Add auth bypass for development * Adjusted legacy extension upload message for ATN * Add contextmanager function to hack around test fixtures and addons-linter woes * Update ci workflow * Lots of test fixes
MelissaAutumn
force-pushed
the
master-2019
branch
from
988b4ce to
1dcc8bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial rebase of AMO (tag:2019.02.28) to ATN master:
This is a rebase up to the 2019.02.28 tag on AMO, right before they removed the django front-end. It's probably a good base to then upgrade as we need it. Tests are currently failing due to some category shenanigans (overlapping ids, changed ids, etc...) and some other minor issues. But the only thing failing on the web-side is the addon upload (due to the category issue.)
I'm sure there were Thunderbird specific tweaks I'll have to go back and fix though.