Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django-waffle to 0.15.1 #10708

Merged
merged 4 commits into from
Feb 26, 2019
Merged

Conversation

pyup-bot
Copy link
Contributor

This PR updates django-waffle from 0.14.0 to 0.15.1.

Changelog

0.15.1

=======
- Optionally logging missing flags, samples, and switches
- Added --users option to waffle_flag management command
- Updated testutils to flush caches
- Improved admin site for users and groups
- Fixed global cache thread safety issues

0.15.0

=======
- Dropped support for Django < 1.11
- Dropped support for Python 3.3
- Added settings `WAFFLE_CREATE_MISSING_(FLAG|SWITCHES|SAMPLES)` to optionally 
create missing objects in the database automatically
- Allow serializing/de-serializing waffle models by natural key
- Added pluggable Flag model
Links

@eviljeff
Copy link
Member

looks like we have a failure in one of our ES tests: https://travis-ci.org/mozilla/addons-server/jobs/494221610#L1651

@eviljeff eviljeff self-assigned this Feb 22, 2019
@eviljeff eviljeff requested a review from diox February 22, 2019 19:16
Copy link
Member

@diox diox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do it inside create_switch, create_flag and create_sample instead, flushing every time ?

For the record this is an interesting problem: waffle does flush itself in save(), but it does that on_commit, and inside tests the transaction hasn't been committed at that point... It wouldn't happen if we were only using their test utils but we had issues with those in the past.

@eviljeff
Copy link
Member

I was initially confused why we didn't see the same problem with every test that had to manipulate a waffle switch but it's actually pretty rare* for us to actually create a switch (and then want to toggle it) rather than just using override_switch.

*13 times vs 106

@diox diox self-assigned this Feb 26, 2019
@diox diox merged commit d606d3b into master Feb 26, 2019
@wagnerand wagnerand deleted the pyup-update-django-waffle-0.14.0-to-0.15.1 branch July 2, 2019 14:43
MelissaAutumn pushed a commit to thunderbird/addons-server that referenced this pull request Aug 25, 2024
* Update django-waffle from 0.14.0 to 0.15.1
* Flush waffle after changing their values in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants