Fix flaky SearchTest.test_compat_override test #10601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It depends on the cache key being different for the cached compat info, and using seconds precision to generate it wasn't enough. We could probably use a completely random value instead, but switching to milliseconds keeps it an ever-incrementing value as before and should be safer.
EnTeQuAk
approved these changes
Feb 5, 2019
MelissaAutumn
pushed a commit
to thunderbird/addons-server
that referenced
this pull request
Aug 25, 2024
It depends on the cache key being different for the cached compat info, and using seconds precision to generate it wasn't enough. We could probably use a completely random value instead, but switching to milliseconds keeps it an ever-incrementing value as before and should be safer. Fix #10599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It depends on the cache key being different for the cached compat info, and using seconds precision to generate it wasn't enough. We could probably use a completely random value instead, but switching
to milliseconds keeps it an ever-incrementing value as before and should be safer.
Fix mozilla/addons#6374