-
Notifications
You must be signed in to change notification settings - Fork 0
CHE-9595: Define terminal api for plugin model. #24
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Also move to dev dependencies the core package so plugin's won't have transitive dependencies to core Change-Id: I2b08265ba411fdf561d52b822dde3c517622a3f3 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
…e, Linking is performed dynamically by providing '@theia/plugin' object on the fly Only the module declaration should be exported in package.json -> So we provide a node cache entry of '@theia/plugin' on the fly Change-Id: I3af8883122c2d0ecfad94c69c1eaf15cb94a0071 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
Change-Id: I5288617ebdf93469d33fe0e1508919ea137657d5 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
this PR implements - retrieving metadata from plugins and using the metadata for plugin activation and deactivation; - pluggability, which allows extending the plugin system to run different types of plugins.
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
* Split hosted and main part in two folders also make CI green again
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
- update as well the version of the wiptheia dependencies
* Handle the deployment with deployers ENV THEIA_PLUGINS can be set for example to local-dir:/Users/benoitf/theia-plugins to deploy all plugins from this directory at startup Also add widget view and some vscode handlers
allow to override more stuff on init and load steps
…on (#17) * Add support for plugins hosted on github repository in releases section
* Add support for vscode:extension/ resolver and http(s):// resolver
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
…ples. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
packages/plugin/src/theia.d.ts
Outdated
/** | ||
* Human readable representation of the terminal in the UI. | ||
*/ | ||
name?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent ?
packages/plugin/src/theia.d.ts
Outdated
/** | ||
* Current working directory. | ||
*/ | ||
cwd?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent ?
packages/plugin/src/theia.d.ts
Outdated
/** | ||
* Environment variables for terminal in format key - value. | ||
*/ | ||
env?: { [key: string]: string | null }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent ?
hello, could you please open upstream PR for all the work not related to plugin's model ? (all that is not part of packages/plugin-ext) so we can merge it upstream |
@benoitf upstream pull request created. |
@AndrienkoAleksandr yes I saw that. Thanks. Once it is merged upstream we can rebase this branch against upstream master and then review the stuff specific to terminal API in plugin-ext |
b09e7bb
to
b9a2ee8
Compare
Define terminal api for plugin model.
Related issue: eclipse-che/che#9595
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com