This repository has been archived by the owner on Jun 20, 2018. It is now read-only.
Fix server shutdown #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evidolob
reviewed
May 2, 2018
packages/plugin-ext/package.json
Outdated
| @@ -5,15 +5,16 @@ | |||
| "dependencies": { | |||
| "@theia/core": "^0.3.8", | |||
| "@theia/filesystem": "^0.3.8", | |||
| "@theia/workspace": "^0.3.8" | |||
| "@theia/workspace": "^0.3.8", | |||
| "ps-tree": "latest" | |||
There was a problem hiding this comment.
Please use version that will be approved in eclipse CQ
mmorhun
force-pushed
the
CHE-9212_2-fix-server-shutdown
branch
from
2487c99 to
38f92b4
Compare
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
mmorhun
force-pushed
the
CHE-9212_2-fix-server-shutdown
branch
from
38f92b4 to
775a801
Compare
benoitf
approved these changes
May 2, 2018
evidolob
approved these changes
May 3, 2018
|
@mmorhun do we need type B for this CQ as it will be part of Theia which is type A I think ? |
|
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=16197 seems we can check in for now |
benoitf
pushed a commit
that referenced
this pull request
May 29, 2018
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 4, 2018
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 13, 2018
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 18, 2018
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 18, 2018
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 19, 2018
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
benoitf
pushed a commit
that referenced
this pull request
Jun 19, 2018
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun mmorhun@redhat.com
This PR fixes Theia server shutdown problem in case of electron and backend in docker container.
This PR introduces new external dependency: ps-tree
Fixes: eclipse-che/che#9367