Skip to content
This repository has been archived by the owner on Jun 20, 2018. It is now read-only.

Introduce a command to deploy on the fly a plugin into Theia #22

Merged
merged 1 commit into from
May 29, 2018

Conversation

benoitf
Copy link

@benoitf benoitf commented May 29, 2018

No description provided.

@benoitf benoitf force-pushed the add-command-deploy branch from d5f4c14 to 3708f18 Compare May 29, 2018 09:08
@mmorhun
Copy link

mmorhun commented May 29, 2018

What happens if plugin is invalid?

@benoitf
Copy link
Author

benoitf commented May 29, 2018

@mmorhun it won't be deployed if plugin is invalid

@mmorhun a next step is to add support for handling all error case (like using a wrong API, duplicate commands registration, etc, allow to uninstall/de-register plugins, etc)

@benoitf benoitf merged commit 639ad3d into master May 29, 2018
@benoitf benoitf deleted the add-command-deploy branch May 29, 2018 09:51
benoitf added a commit that referenced this pull request Jun 19, 2018
Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants