feat: Support managed_draining argument at aws_ecs_capacity_provider

[ivan-sukhomlyn]

Description

Support of managed_draining argument at auto_scaling_group_provider block of aws_ecs_capacity_provider resource introduced by

• v5.34.0 of the Terraform AWS Provider.
• r/aws_ecs_capacity_provider: add manged_draining argument hashicorp/terraform-provider-aws#35421

Motivation and Context

• Resolves feat: add managed_draining to aws_ecs_capacity_provider #156

Breaking Changes

⚠️ Minimal required AWS provider version is >=5.34.0

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

For already created ECS ASG capacity provider:

• config

module "ecs_cluster" {
  source = "../../../../../../open-source/terraform-aws-ecs/modules/cluster"

  cluster_name = local.ecs_cluster_name

  # Capacity provider - autoscaling groups
  default_capacity_provider_use_fargate = false

  autoscaling_capacity_providers = {
    for k, v in module.asg_ecs : "${local.ecs_cluster_name}-${k}" => {
      auto_scaling_group_arn         = v.autoscaling_group_arn
      managed_draining               = "ENABLED"
# ....
}

• Terraform running

$ terraform init -upgrade && terraform plan
...
- Installing hashicorp/aws v5.34.0...
- Installed hashicorp/aws v5.34.0 (signed by HashiCorp)
...


  # module.ecs_cluster.aws_ecs_capacity_provider.this["xxxxx"] will be updated in-place
  ~ resource "aws_ecs_capacity_provider" "this" {
        id       = "arn:aws:ecs:xxx:xxx:capacity-provider/xxxxx"
        name     = "xxxx"

        # (2 unchanged attributes hidden)

      ~ auto_scaling_group_provider {
          ~ managed_draining               = "DISABLED" -> "ENABLED"
            # (2 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }
    }

• I have executed pre-commit run -a on my pull request

✗ pre-commit run -a
Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform validate.......................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed

[bryantbiggs]

this is a breaking change - we have a few other breaking changes batched up now so we should do them all at once

also - the version would need to be aligned across the project

[ivan-sukhomlyn]

@bryantbiggs should I do something additionally from my side in that case?

[remiflament]

yes @ivan-sukhomlyn the versions.tf should be the same in all the project. So it needs to be update in all the other submodules.

[ivan-sukhomlyn]

oops!
@remiflament thank you for the clarification 👍 🙂

[bryantbiggs]

Thank you! Merging this into the wip/v6 branch

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.