-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add managed_draining to aws_ecs_capacity_provider #156
Comments
Please make a PR with this change. |
@antonbabenko Let me prepare a PR 🙂 |
resolved in #123 |
just to clarify with the correct link: |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
AWS provider v5.34.0 added this functionality
The minimum version of the module needs to be update as
>= 5.34.0
Description of this feature :
Now if you create a new ecs_capacity_providre it automatically comes with managed_draining as true.
I tested it by destroy/re-apply one of my sandbox stack using this module in version
5.7.4
It could be beneficial to manage whether we want or not this feature.
We have a clear documentation of the combination of
managed_termination
andmanaged_draining
on the official docI didn't start the PR because I was not sure about the things to do with the upgrade of the minimum version.
Thank you
The text was updated successfully, but these errors were encountered: