Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add managed_draining to aws_ecs_capacity_provider #156

Closed
remiflament opened this issue Jan 26, 2024 · 5 comments · Fixed by #158
Closed

feat: add managed_draining to aws_ecs_capacity_provider #156

remiflament opened this issue Jan 26, 2024 · 5 comments · Fixed by #158
Milestone

Comments

@remiflament
Copy link

remiflament commented Jan 26, 2024

AWS provider v5.34.0 added this functionality

The minimum version of the module needs to be update as >= 5.34.0

Description of this feature :

Now if you create a new ecs_capacity_providre it automatically comes with managed_draining as true.
I tested it by destroy/re-apply one of my sandbox stack using this module in version 5.7.4

It could be beneficial to manage whether we want or not this feature.
We have a clear documentation of the combination of managed_termination and managed_draining on the official doc

I didn't start the PR because I was not sure about the things to do with the upgrade of the minimum version.

Thank you

@antonbabenko
Copy link
Member

Please make a PR with this change.

@ivan-sukhomlyn
Copy link
Contributor

@antonbabenko Let me prepare a PR 🙂

@bryantbiggs
Copy link
Member

resolved in #123

@ivan-sukhomlyn
Copy link
Contributor

just to clarify with the correct link:
resolved in #158

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants