Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable managed draining for autoscaling_capacity_providers in ecs cluster #174

Closed
purplepangolin opened this issue Feb 27, 2024 · 3 comments

Comments

@purplepangolin
Copy link

Is your request related to a new offering from AWS?

Amazon recently announced managed instance draining

a new capability that facilitates graceful shutdown of workloads deployed on Amazon Elastic Compute Cloud (Amazon EC2) instances by safely stopping and rescheduling workloads to other, non-terminating instances.

Is this functionality available in the AWS provider for Terraform?

  • Yes ✅:
    Support for this was added to the terraform aws provider in release v5.34.0 and its use is documented here.

Is your request related to a problem? Please describe.

This feature is available by setting the managed_draining property on aws_ecs_capacity_provider but is not exposed in auto_scaling_group_provider

Describe the solution you'd like.

Amend the implementation of how variable "autoscaling_capacity_providers" gets passed down to this block to propagate the managed_draining setting in the same way as is done for managed_termination_protection. This will need to be gated so that it is only set for aws provider 5.34.0 and above.

Describe alternatives you've considered.

Additional context

@easterbonbon
Copy link

Hey there, it sounds like the changes coming up in v6 may address your issue here. Here's the relevant PR: #158

@purplepangolin
Copy link
Author

Thanks @easterbonbon, was just about to open a pr for that myself as I hadn't spotted that one.

Copy link

github-actions bot commented Apr 6, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants