Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Memory Leak - Revert terafoundation_kafka_connector to 1.0.0, pin node version to 22.12.0 #39

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Test Memory Leak - Revert terafoundation_kafka_connector to 1.0.0, pin node version to 22.12.0 #39

merged 2 commits into from
Feb 4, 2025

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Feb 4, 2025

This PR makes the following changes:

  • set the terafoundation_kafka_connector to version 1.0.0 in the Dockerfile
  • pin the node version to 22.12.0 in the release.yml and build.yml workflows

This base image will be used to test a memory leak and should be reverted when testing is finished.

@busma13 busma13 requested a review from godber February 4, 2025 21:15
@godber godber merged commit aced93d into master Feb 4, 2025
3 checks passed
@godber godber deleted the revert-kafka-connector-to-1.0.0 branch February 4, 2025 21:19
@busma13 busma13 mentioned this pull request Feb 5, 2025
Merged
godber pushed a commit that referenced this pull request Feb 5, 2025
@busma13
revert test changes, fix ENV declarations (#41)
1dd2dd5 
This PR makes the following changes:
- revert changes from #39 used to test memory leak
  - terafoundation_kafka_connector from 1.0.0 to 1.2.1
  - unpin node 22 version in build and release workflows
- fix `Dockerfile` LegacyKeyValueFormat warnings (see: #40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@busma13 @godber