Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert test changes, fix ENV declarations #41

Merged
merged 1 commit into from
Feb 5, 2025
Merged

revert test changes, fix ENV declarations #41

merged 1 commit into from
Feb 5, 2025

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Feb 5, 2025

This PR makes the following changes:

@busma13 busma13 requested a review from sotojn February 5, 2025 22:42
@godber
Copy link
Member

godber commented Feb 5, 2025

We can come back and fix the remaining args.

@godber godber merged commit 1dd2dd5 into master Feb 5, 2025
3 checks passed
@godber godber deleted the revert-test-changes branch February 5, 2025 22:43
sotojn
sotojn approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@sotojn sotojn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@busma13
Copy link
Contributor Author

busma13 commented Feb 5, 2025

The remaining warnings are because we don't provide defaults. Is this something we want to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

@sotojn sotojn sotojn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busma13 @godber @sotojn