Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Memory Leak - Revert terafoundation_kafka_connector to 1.0.0, pin node version to 22.12.0 #39

Merged
merged 2 commits into from
Feb 4, 2025
+4 −4
Merged

Test Memory Leak - Revert terafoundation_kafka_connector to 1.0.0, pin node version to 22.12.0 #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe8498e
revert kafka connector to 1.0.0
busma13 Feb 4, 2025
09a6cca
pin node version to 22.12.0
busma13 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
# In the case where a new node version introduces a breaking change,
# replace the major version of the matrix to a pinned version here.
# Ex: ["18", "20", "22"] ---> ["18.19.1", "20", "22"]
version: ["18", "20", "22"]
version: ["18", "20", "22.12.0"] # pinning node 22 for testing purposes, revert after tests
runs-on: ubuntu-22.04
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
# In the case where a new node version introduces a breaking change,
# replace the major version of the matrix to a pinned version here.
# Ex: ["18", "20", "22"] ---> ["18.19.1", "20", "22"]
version: ["18", "20", "22"]
version: ["18", "20", "22.12.0"] # pinning node 22 for testing purposes, revert after tests
runs-on: ubuntu-22.04
permissions:
contents: read
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG NODE_VERSION
FROM node:${NODE_VERSION}-alpine

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (18)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (20)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (22.12.0)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

ARG GITHUB_SHA
ARG BUILD_TIMESTAMP
Expand Down Expand Up @@ -29,8 +29,8 @@
bsd-compat-headers \
py-setuptools

ENV NPM_CONFIG_LOGLEVEL error

Check warning on line 32 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (18)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 32 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (20)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 32 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (22.12.0)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV WITH_SASL 0

Check warning on line 33 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (18)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 33 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (20)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 33 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (22.12.0)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN node --version
RUN yarn --version
Expand All @@ -55,7 +55,7 @@
--build \
--no-package-lock \
--no-optional \
'terafoundation_kafka_connector@~1.2.1' \
'terafoundation_kafka_connector@~1.0.0' \
&& npm cache clean --force

RUN apk del .build-deps
Expand All @@ -68,7 +68,7 @@
COPY docker-pkg-fix.js /usr/local/bin/docker-pkg-fix
COPY wait-for-it.sh /usr/local/bin/wait-for-it

ENV NODE_OPTIONS "--max-old-space-size=2048"

Check warning on line 71 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (18)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 71 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (20)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 71 in Dockerfile

View workflow job for this annotation

GitHub Actions / build_matrix (22.12.0)

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

LABEL org.opencontainers.image.created="$BUILD_TIMESTAMP" \
org.opencontainers.image.documentation="https://github.com/terascope/base-docker-image/blob/master/README.md" \
Expand All @@ -78,7 +78,7 @@
org.opencontainers.image.title="Node-base" \
org.opencontainers.image.vendor="Terascope" \
io.terascope.image.node_version="$NODE_VERSION" \
io.terascope.image.kafka_connector_version="1.2.1"
io.terascope.image.kafka_connector_version="1.0.0"

# Use tini to handle sigterm and zombie processes
ENTRYPOINT ["/sbin/tini", "--"]