Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #217 - set logs class in log-view in step logs #244

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

sbke-mms
Copy link
Collaborator

This is done in the steps.html analog to the virtual log view in the logs.html

Description

Fixes #217

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

This is done in the steps.html analog to the virtual log view in the logs.html
@sbke-mms
Copy link
Collaborator Author

Fixed Method view example

Copy link

@Zsar Zsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably deduplicate a bit between log-view and virtual-log-view, but I'd have to have a more thorough look. Going to raise an issue for that and approve here in the meanwhile.

@Zsar Zsar linked an issue Jun 23, 2022 that may be closed by this pull request
@martingrossmann martingrossmann merged commit 06b8b11 into master Jun 24, 2022
@martingrossmann martingrossmann deleted the fix/format_method_logs branch June 24, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Report] Format method logs like the console logs/test logs
3 participants