Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Remove the text_message_service from the wallet #2740

Merged
merged 1 commit into from
Mar 15, 2021
Merged

[chore] Remove the text_message_service from the wallet #2740

merged 1 commit into from
Mar 15, 2021

Conversation

philipr-za
Copy link
Contributor

Description

The text_message_service was an idea in the very early days of the code base and it was put on hold so it was just commented out but the code base has moved on significantly and it was never removed.

This PR axes it finally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I ran cargo test successfully before submitting my PR.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@philipr-za
[chore] Remove the text_message_service from the wallet
0780fee 
The text_message_service was an idea in the very early days of the code base and it was put on hold so it was just commented out but the code base has moved on significantly and it was never removed.

This PR axes it finally.
sdbondi
sdbondi approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bye bye code

SWvheerden
SWvheerden approved these changes Mar 12, 2021
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Although I personally think having a text message service in aurora will be great and of benefit, it's currently not used there. And this code is not lost forever

@philipr-za
Copy link
Contributor Author

LGTM
Although I personally think having a text message service in aurora will be great and of benefit, it's currently not used there. And this code is not lost forever

It's also from the first days of the wallet so is like two refactors and architecture updates old so would have to reimplement anyway.

@stringhandler stringhandler merged commit 06bc44b into tari-project:development Mar 15, 2021
stringhandler added a commit that referenced this pull request Apr 1, 2021
@stringhandler
v0.8.7
8076922 
Changes since v0.8.6

Wallet
---
- [#2825](#2825) [wallet] correctly log RPC error messages
- [#2824](#2824) [wallet] Output error message for ConfigError
- [#2818](#2818) [wallet] get_transaction_info no longer errors if any transaction is not found
- [#2819](#2819) [wallet] Clear UI before starting UI loop
- [#2798](#2798) [wallet] Add MinedUnconfirmed to command mode wait stage
- [#2793](#2793) [wallet] Add menu to console wallet
- [#2765](#2765) [wallet] Friendly incorrect password message
- [#2753](#2753) [wallet] Update base node service to use RPC
- [#2762](#2762) [wallet] Implement wallet recovery process in LibWallet FFI
- [#2761](#2761) [wallet] Differentiate "funds pending" case in UTXO selection
- [#2748](#2748) [wallet] Added saf message duration to configuration

Base Node
---
- [#2814](#2814) [base-node] Add previous hash check to sync validator
- [#2759](#2759) [base-node] Fix handling of large chain reorgs in header sync
- [#2813](#2813) [base-node] Add rewind-blockchain and improve header-stats command
- [#2795](#2795) [base-node] Update mempool consensus validator to check weight excluding coinbase
- [#2738](#2738) [base-node] Rewind prune mode behind horizon
- [#2768](#2768) [base-node] Add transaction consensus validator
- [#2764](#2764) [base-node] Remove reorgs from total tx count
- [#2755](#2755) [base-node] Node bootstraps after initial sync if all other nodes are h=0
- [#2751](#2751) [base-node] Minor fix for list-headers

Mining
---
- [#2807](#2807) [merge-mining] Added getLastBlockHeader cucumber test
- [#2792](#2792) [mining-node] Added additional command line arguments
- [#2791](#2791) [merge-mining] Add stdout information
- [#2767](#2767) [mmproxy] Expanded cucumber tests for merged mining proxy
- [#2743](#2743) [merge-mining] Fix logic flaw in proxy_request_to_monerod

Other
---
- [#2826](#2826) [common] Add rpc_max_simultaneous_sessions setting to config
- [#2823](#2823) [chore] Fix import
- [#2822](#2822) [chore] Update prettier paths
- [#2815](#2815) [comms] Connection manager requester not exposed on CommsNode
- [#2820](#2820) [chore] Use prettier for integration tests
- [#2821](#2821) [other] Add memory net summary
- [#2757](#2757) [ci] Add all-targets to clippy
- [#2796](#2796) [docs] Add WalletNotify info to config samples
- [#2773](#2773) [tests] Add custom log file paths for wallet and mmproxy
- [#2763](#2763) [tests] Update mempool waits to be dynamic
- [#2769](#2769) [ci] Increase Cucumber CI to include all tests except "long running"
- [#2747](#2747) [docs] Update rfc 201 for coinbase
- [#276](#276) [chore] Removed some unused dependencies
- [#2576](#2576) [common] Increase flood ban config
- [#2572](#2572) [tests] Add cucumber test verify meddling with MMR sizes
- [#2754](#2754) [common] Emit rerun-if-changed directives for include protos
- [#2745](#2745) [ci] Point Circle CI status badge to development branch only
- [#2744](#2744) [docs] Minor Fixes
- [#2740](#2740) [chore] Remove the text_message_service from the wallet (#2740)
- [#2739](#2739) [docs] Document the NO_OP TariScript vulnerability
@stringhandler stringhandler mentioned this pull request Apr 1, 2021
Merged
13 tasks
@philipr-za philipr-za deleted the philip-remove-tms branch June 8, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdbondi sdbondi sdbondi approved these changes

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philipr-za @sdbondi @SWvheerden @stringhandler