Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API version for ItemLookup to 2013-08-01 #35

Merged
merged 1 commit into from
Jan 8, 2016
Merged

Update API version for ItemLookup to 2013-08-01 #35

merged 1 commit into from
Jan 8, 2016

Conversation

FdezRomero
Copy link
Contributor

Changed API version from 2011-08-01 to 2013-08-01 when using the ItemLookup method as discussed in #26. All tests are passing OK.

You may want to update the dependencies (the badge is showing yellow at the moment) and bump the package version to NPM afterwards.

Thanks!

Changed API version from 2011-08-01 to 2013-08-01 when using the
ItemLookup method.
@t3chnoboy
Copy link
Owner

Great! Thanks @FdezRomero
I'll publish a new version.

t3chnoboy added a commit that referenced this pull request Jan 8, 2016
Update API version for ItemLookup to 2013-08-01
@t3chnoboy t3chnoboy merged commit 32b867e into t3chnoboy:master Jan 8, 2016
@FdezRomero
Copy link
Contributor Author

Awesome! Thanks @t3chnoboy

@t3chnoboy
Copy link
Owner

@masterT @JuanCrg90 Can you guys please publish a new version?
I got problems with my private npm server and npm registry configuration 😁

@masterT
Copy link
Collaborator

masterT commented Jan 8, 2016

All right 🚢!

@masterT
Copy link
Collaborator

masterT commented Jan 8, 2016

@t3chnoboy @FdezRomero Something is broken!

@masterT
Copy link
Collaborator

masterT commented Jan 10, 2016

@t3chnoboy @FdezRomero First time the specs were run by Travis CI, some did not passed. Amazon returns an unexpected error because there were to much request sent in a too short time.

I will update the specs now so it won't happened again.

@masterT
Copy link
Collaborator

masterT commented Jan 10, 2016

Here is the Amazon error:

$: { xmlns: 'http://ecs.amazonaws.com/doc/2013-08-01/' },
  Error: [
    {
      Code: [ 'RequestThrottled' ],
      Message: [
        'AWS Access Key ID: AKIAIXILNIR67IOXLNHA. You are submitting requests too quickly. Please retry your requests at a slower rate.'
      ]
    }
  ],
  RequestId: [ '6a410764-3977-4149-bdfd-383893c15992' ]
}

@arjunkori
Copy link

Same here,
I am getting the same error as @masterT mentioned above.

@masterT
Copy link
Collaborator

masterT commented Feb 20, 2017

This is because you have a maximum rate of 1 request per seconde per IP address. You need to throttle your request. @arjunkori check the issue #37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants