-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request Throttling #37
Comments
Hey @FdezRomero! |
Hi @t3chnoboy, I chose Bottleneck over node-rate-limiter because it allows to create a different keys/queues for each API endpoint and seemed very lightweight and performant (the creators use it for production DNS). However, I'm not sure if some endpoints are counted together for the rate limiting or not, I found contradictory information about this. Anyway, I have no preference in using these libraries or a custom implementation as long as it supports concurrency. You can find an example of the MaxQPS I mentioned before in bottlenose, a client written in Python (I haven't used it myself). Thanks! |
Hi @FdezRomero. I recently ran into the same throttling issue and found that global throttling, i.e. not per-endpoint throttling, was the solution. Putting https://github.com/jhurliman/node-rate-limiter, as @t3chnoboy suggested, in front of all requests worked well. |
Thanks @kaijuliu, knowing that the limit is actually global and not per endpoint really helps 👍 |
@t3chnoboy can we close this issue? |
Hi all!
This is a question rather than an issue: What is in your opinion the best way to throttle requests to the Amazon Product API? The initial limit is 1 req/s, increasing by 1 req/s for every $4,700 in goods sold by your
awsTag
.I'm currently using Bottleneck with a limit of 1 request per 2000ms and I'm still getting many
RequestThrottled
errors. So it doesn't seem to be playing well with this module or the API.Are any of you throttling your requests? How? It would be great if this feature was included, as similar projects in other languages have a
MaxQPS
option.Thanks!
The text was updated successfully, but these errors were encountered: