Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Any reason not to use the latest version of the API? #26

Closed
FdezRomero opened this issue Sep 4, 2015 · 8 comments
Closed

Comments

@FdezRomero
Copy link
Contributor

Hi guys,

Out of curiosity, I just wanted to know if there is any reason not to use the latest version of the Amazon Product Advertising API (2013-08-01). Are there any differences or performance related? Maybe for compatibility/legacy support?

Thanks!

@masterT
Copy link
Collaborator

masterT commented Sep 8, 2015

That is a good question @t3chnoboy

@kaue
Copy link
Contributor

kaue commented Sep 8, 2015

Here is some info from the API docs:

The version of the Product Advertising API software and WSDL to use. By default, the 2011-08-01 version is used. Alternately, specify a software version, such as 2013-08-01. For a list of valid version numbers, refer to the Product Advertising API Release Notes. Note that the latest version of Product Advertising API is not used by default.
Default: 2011-08-01
Valid values: Valid WSDL version date, for example, 2013-08-01.

Source: http://docs.aws.amazon.com/AWSECommerceService/latest/DG/CommonRequestParameters.html

@t3chnoboy
Copy link
Owner

afaik, the version we use (2013-08-01) is the latest

@FdezRomero
Copy link
Contributor Author

@t3chnoboy For ItemLookup it seems to be using 2011-08-01: https://github.com/t3chnoboy/amazon-product-api/blob/master/lib/utils.js#L73

@t3chnoboy
Copy link
Owner

@FdezRomero hmmm Can you try changing it to the latest version and make sure all tests are passing?

@FdezRomero
Copy link
Contributor Author

I'll try some time this week @t3chnoboy. Not that I found a need or something not working as expected, I was just curious about using a different API version for this operation.

@FdezRomero
Copy link
Contributor Author

Finally I found the time to test changing the API version to 2013-08-01 and everything is working as expected. I also noticed a tiny speed improvement when many variants are returned, but might be unrelated.

Sent PR #35 with the change.

@masterT
Copy link
Collaborator

masterT commented Jan 27, 2017

@t3chnoboy can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants