Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(documentation): restructurs components folder now contains subfolders Forms, Ions, Internet and Intranet Header #2175

Merged
merged 10 commits into from
Dec 6, 2023

Conversation

b1aserlu
Copy link
Contributor

@b1aserlu b1aserlu commented Nov 1, 2023

Alternative Version to #2172 .
Was chosen and as discussed the headers and the icons documentation are now also subfolders of components.

image

@b1aserlu b1aserlu linked an issue Nov 1, 2023 that may be closed by this pull request
Copy link

changeset-bot bot commented Nov 1, 2023

⚠️ No Changeset found

Latest commit: a3d690c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

corrects an issue where the imports did not work
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Nov 1, 2023

Preview environment ready: https://preview-2175--swisspost-design-system-next.netlify.app

@b1aserlu b1aserlu linked an issue Nov 30, 2023 that may be closed by this pull request
5 tasks
@b1aserlu b1aserlu marked this pull request as ready for review November 30, 2023 09:32
@b1aserlu b1aserlu changed the title feat(documentation): adds new "forms" folder alternative version feat(documentation): restructurs components folders now contains subfolders Forms, Ions, internet and intranet Header Nov 30, 2023
@b1aserlu b1aserlu changed the title feat(documentation): restructurs components folders now contains subfolders Forms, Ions, internet and intranet Header feat(documentation): restructurs components folder now contains subfolders Forms, Ions, internet and intranet Header Nov 30, 2023
@b1aserlu b1aserlu changed the title feat(documentation): restructurs components folder now contains subfolders Forms, Ions, internet and intranet Header feat(documentation): restructurs components folder now contains subfolders Forms, Ions, Internet and Intranet Header Nov 30, 2023
Copy link
Contributor

@imagoiq imagoiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is much better. The only thing bothering me is that folders inside components are listed at the top. I would prefer them mixed with single file and that everything is orderer alphabetically.

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@b1aserlu
Copy link
Contributor Author

b1aserlu commented Dec 5, 2023

To prevent manually maintaining order we could think about renaming "Getting Started" stories to "_Getting Started" or sth similar that way we could have the components folder sort without interferance. The way it is right now the previwe.ts fille needs to ne manually updated every time a story with a lower asci value than "Intranet Header" is added.

@b1aserlu b1aserlu requested a review from imagoiq December 5, 2023 15:32
@b1aserlu b1aserlu merged commit 48f4853 into main Dec 6, 2023
9 checks passed
@b1aserlu b1aserlu deleted the 976-group-form-elements-alternative branch December 6, 2023 08:06
imagoiq added a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group Storybook Group Form Elements
3 participants