Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(documentation): adds new folder "forms" for form-control based components #2172

Closed
wants to merge 5 commits into from
Closed

feat(documentation): adds new folder "forms" for form-control based components #2172

wants to merge 5 commits into from

Conversation

b1aserlu
Copy link
Contributor

@b1aserlu b1aserlu commented Oct 31, 2023 •
edited
Loading

Version From folder on the same level as the Components folder. Bootstrap does this as well https://getbootstrap.com/docs/5.3/forms/overview/

PS:
I am not sure if the following components: [radio-card, checkbox-card] would be considered part of forms or part of the normal components. I considered them as part of the forms group for now.

@b1aserlu
feat(documentation): adds new folder for form-control based components
f9d03f0 
moves all form-control based components to the new folder
@b1aserlu
feat(documentation): adds new folder "forms" for form-control based c…
1cbe660 
…omponents

adjusts preview.ts to show the Forms right under the components
adjust all story.ts meta information so they show up in story book correctly
@b1aserlu b1aserlu linked an issue Oct 31, 2023 that may be closed by this pull request
Group Form Elements #976
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: de2c0e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Oct 31, 2023 •
edited
Loading

Preview environment ready: https://preview-2172--swisspost-design-system-next.netlify.app

@b1aserlu b1aserlu mentioned this pull request Nov 1, 2023
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gfellerph gfellerph added 💚 APPROVED Review state and removed 💚 APPROVED Review state labels Nov 9, 2023
@b1aserlu
Copy link
Contributor Author

This option was discarded

@b1aserlu b1aserlu closed this Nov 30, 2023
b1aserlu added a commit that referenced this pull request Dec 6, 2023
@b1aserlu
feat(documentation): restructurs components folder now contains subfo…
48f4853 
…lders Forms, Ions, Internet and Intranet Header (#2175)

Alternative Version to #2172 .
Was chosen and as discussed the headers and the icons documentation are
now also subfolders of components.


![image](https://github.com/swisspost/design-system/assets/141234680/32d0d194-7535-4fa6-bb72-96226a253680)
@oliverschuerch oliverschuerch deleted the 976-group-form-elements branch February 21, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group Form Elements
3 participants
@b1aserlu @swisspost-bot @gfellerph