-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e are not started when only documentation changes #2364
Comments
The third point would probably be the cleanest solution. We could easily use fixture html files like we already use for the language tests for all other header tests. The components suffer from the same issue. There, for example for the popover tests, the component is embedded in the storybook iframe which puts a div.overflow-hidden around the button that triggers the popover. The popover is then displayed "outside" of the div area and cypress thinks it's not visible and fails the If only component testing for stencil would work (cypress-io/cypress#24054)... As a bonus, this would make the tests faster because we don't have to compile the docs before the test. As a malus, we have to maintain separate markup for test cases. |
Storybook stories are rendered inside some wrapper elements, one of which has overflow: hidden set. For this component, that's a problem because cypress then thinks the popover is not visible as it overlaps the containers bounds. Using a fixture creates the most simple environment possible and increases test stability. Also, see #2364.
Let's think about it and make a decision on the next triage |
Decided to go with option 3 |
Closing as won't fix. |
e2e test were not triggered on CI with #2175
Pnpm did not trigger the internet-header tests because there were no change there and there is no dependency for the documentation on the internet-header packages. But in reality, there is a dependency between the two as the Cypress test are using the documentation to test the component.
We could add the documentation as a dependency in the package.json, but this creates a loop as the documentation is using the internet-header package to display the component.
So we should either:
The text was updated successfully, but these errors were encountered: