Update: Adding compatibility for Angular 8 #1690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyboris
reviewed
May 29, 2019
| "@angular/platform-browser": "^7.0.0", | ||
| "@angular/platform-browser-dynamic": "^7.0.0", | ||
| "@angular/platform-server": "^7.0.0", | ||
| "@angular/animations": "^8.0.0-rc.3", |
There was a problem hiding this comment.
Angular 8 just came out -- perhaps bump these to `"^8.0.0" ? 🙂
whyboris
approved these changes
May 29, 2019
|
🙇 Dear swimlane team -- our production project can not upgrade to Angular 8 because this PR hasn't been merged. Please merge it soon and draft a new npm release 🙇 ❤️ much appreciated ❤️ |
|
I am currently working on this. Angular 8 seems to require a few more changes (adding the |
|
See #1697 Would appreciate if anyone would give it a test before I merge and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The current version is pulling DOCUMENT from platform-browser. With angular 8 this is deprecated and now pulls from common. This PR corrects for the new import.
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Requires Angular >8
Other information: